Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Shuo Liu, Tim Chu, Ziang Wang.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81440?usp=email )
Change subject: soc/intel/xeon_sp: Add device to proximity domain map utils
......................................................................
Patch Set 7: Code-Review+1
(6 comments)
File src/soc/intel/xeon_sp/include/soc/numa.h:
https://review.coreboot.org/c/coreboot/+/81440/comment/7cbae54a_261f0ce1 :
PS7, Line 13: XEONSP_PROXIMITY_DOMAIN_MAX
`XEONSP_INVALID_PD_INDEX` maybe?
File src/soc/intel/xeon_sp/numa.c:
https://review.coreboot.org/c/coreboot/+/81440/comment/7ba75ec7_724e80e2 :
PS6, Line 122: uint32_t
Nice catch! Updated.
Done
https://review.coreboot.org/c/coreboot/+/81440/comment/272cf060_5c66522c :
PS6, Line 130: return PD_TYPE_MAX;
Sure, updated.
Done
File src/soc/intel/xeon_sp/numa.c:
https://review.coreboot.org/c/coreboot/+/81440/comment/c9b33ce1_87fba7f8 :
PS7, Line 129: not finding
could not find
https://review.coreboot.org/c/coreboot/+/81440/comment/52cf8d92_1e87411c :
PS7, Line 137: bounded
nit: `bound` (`bind` is an irregular verb)
https://review.coreboot.org/c/coreboot/+/81440/comment/e08dde0b_ed75b6f8 :
PS7, Line 149: not finding
could not find
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81440?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icd14a98823491ccfc38473e44a26dddfbbcaa7c0
Gerrit-Change-Number: 81440
Gerrit-PatchSet: 7
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Ziang Wang
ziang.wang@intel.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 30 Apr 2024 12:05:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment