Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Morgan Jang, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54093 )
Change subject: security/intel/cbnt: Add logging ......................................................................
Patch Set 4:
(9 comments)
File src/security/intel/cbnt/logging.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/fc90a563_7e7e1387 PS4, Line 21: uint64_t : 24; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/ac1529ee_76e8c970 PS4, Line 23: uint64_t : 1; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/b0b9ce6e_06281a0e PS4, Line 25: uint64_t : 29; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/686e04ad_9e7d1cc9 PS4, Line 32: static const char *tpm_type[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/dbd95024_50c47bb9 PS4, Line 41: uint64_t : 59; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/54bac7d0_74655e60 PS4, Line 56: uint32_t : 15; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/9ca0ad7b_52fda7fd PS4, Line 66: uint32_t : 5; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/0f379cfe_38f446f1 PS4, Line 83: uint32_t : 2; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/99dd3049_862ac12f PS4, Line 94: uint32_t : 6; space prohibited before that ':' (ctx:WxW)