Attention is currently required from: Andrey Petrov, Arthur Heymans, Bora Guvendik, Jérémy Compostella, Ronak Kanabar, Shuo Liu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81212?usp=email )
Change subject: drivers/intel/fsp2_0: Support FSP-M execution from CBFS cache
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81212/comment/620d0534_bb47598b :
PS2, Line 12: can
can be
https://review.coreboot.org/c/coreboot/+/81212/comment/7aa6d68b_1e117368 :
PS2, Line 25: | Overall boot time impact | +15.9 ms | +77.4 ms |
Where do the 14 ms difference for LZ4 come from?
https://review.coreboot.org/c/coreboot/+/81212/comment/1ad22eaf_03a5bb41 :
PS2, Line 29: \
Other way /?
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/81212/comment/0adf4f02_ce604e42 :
PS2, Line 225: Select this value when FSP-M execute from CBFS cache
Please add a dot/period at the end of the sentence.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81212?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8d42d765eb0ecf2e7a8fc6d8d15eb2df8975f6f2
Gerrit-Change-Number: 81212
Gerrit-PatchSet: 2
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Tue, 26 Mar 2024 16:40:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment