Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84609?usp=email )
Change subject: soc/intel/mtl to xeon_sp: Explicitly include static.h for config_of_soc ......................................................................
soc/intel/mtl to xeon_sp: Explicitly include static.h for config_of_soc
As per commit 865173153760 ("sconfig: Move config_of_soc from device.h to static.h"), sources that require access to the devicetree should directly include static.h so that it can be removed from device.h, eliminating unnecessary dependencies on static.h for files that only need the types and function declarations in device.h.
Change-Id: I3c118a707dfe7bb8932606f30eae52ef0b4c9efe Signed-off-by: Nicholas Chin nic.c3.14@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/84609 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de --- M src/soc/intel/meteorlake/acpi.c M src/soc/intel/meteorlake/chip.c M src/soc/intel/meteorlake/cpu.c M src/soc/intel/meteorlake/espi.c M src/soc/intel/meteorlake/fsp_params.c M src/soc/intel/meteorlake/pmc.c M src/soc/intel/meteorlake/pmutil.c M src/soc/intel/meteorlake/romstage/fsp_params.c M src/soc/intel/meteorlake/systemagent.c M src/soc/intel/meteorlake/tcss.c M src/soc/intel/pantherlake/acpi.c M src/soc/intel/pantherlake/chip.c M src/soc/intel/pantherlake/cpu.c M src/soc/intel/pantherlake/espi.c M src/soc/intel/pantherlake/fsp_params.c M src/soc/intel/pantherlake/pmc.c M src/soc/intel/pantherlake/pmutil.c M src/soc/intel/pantherlake/romstage/fsp_params.c M src/soc/intel/pantherlake/systemagent.c M src/soc/intel/skylake/acpi.c M src/soc/intel/skylake/bootblock/pch.c M src/soc/intel/skylake/chip.c M src/soc/intel/skylake/cpu.c M src/soc/intel/skylake/fadt.c M src/soc/intel/skylake/lpc.c M src/soc/intel/skylake/pmc.c M src/soc/intel/skylake/pmutil.c M src/soc/intel/skylake/romstage/fsp_params.c M src/soc/intel/skylake/systemagent.c M src/soc/intel/tigerlake/acpi.c M src/soc/intel/tigerlake/bootblock/pch.c M src/soc/intel/tigerlake/chip.c M src/soc/intel/tigerlake/cpu.c M src/soc/intel/tigerlake/espi.c M src/soc/intel/tigerlake/fsp_params.c M src/soc/intel/tigerlake/pmc.c M src/soc/intel/tigerlake/pmutil.c M src/soc/intel/tigerlake/romstage/fsp_params.c M src/soc/intel/tigerlake/systemagent.c M src/soc/intel/xeon_sp/acpi.c M src/soc/intel/xeon_sp/cpx/romstage.c M src/soc/intel/xeon_sp/lpc.c M src/soc/intel/xeon_sp/skx/romstage.c M src/soc/intel/xeon_sp/spr/romstage.c 44 files changed, 44 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved
diff --git a/src/soc/intel/meteorlake/acpi.c b/src/soc/intel/meteorlake/acpi.c index a3ee198..e3aa44e 100644 --- a/src/soc/intel/meteorlake/acpi.c +++ b/src/soc/intel/meteorlake/acpi.c @@ -20,6 +20,7 @@ #include <soc/pm.h> #include <soc/soc_chip.h> #include <soc/systemagent.h> +#include <static.h> #include <types.h>
/* diff --git a/src/soc/intel/meteorlake/chip.c b/src/soc/intel/meteorlake/chip.c index d2011f9..a0a1399 100644 --- a/src/soc/intel/meteorlake/chip.c +++ b/src/soc/intel/meteorlake/chip.c @@ -24,6 +24,7 @@ #include <soc/ramstage.h> #include <soc/soc_chip.h> #include <soc/tcss.h> +#include <static.h>
#if CONFIG(HAVE_ACPI_TABLES) const char *soc_acpi_name(const struct device *dev) diff --git a/src/soc/intel/meteorlake/cpu.c b/src/soc/intel/meteorlake/cpu.c index e990ae3..4a74be0 100644 --- a/src/soc/intel/meteorlake/cpu.c +++ b/src/soc/intel/meteorlake/cpu.c @@ -21,6 +21,7 @@ #include <soc/pci_devs.h> #include <soc/soc_chip.h> #include <soc/soc_info.h> +#include <static.h>
bool cpu_soc_is_in_untrusted_mode(void) { diff --git a/src/soc/intel/meteorlake/espi.c b/src/soc/intel/meteorlake/espi.c index a3952a3..98fd9fc 100644 --- a/src/soc/intel/meteorlake/espi.c +++ b/src/soc/intel/meteorlake/espi.c @@ -13,6 +13,7 @@ #include <soc/pci_devs.h> #include <soc/pcr_ids.h> #include <soc/soc_chip.h> +#include <static.h>
void soc_get_gen_io_dec_range(uint32_t gen_io_dec[LPC_NUM_GENERIC_IO_RANGES]) { diff --git a/src/soc/intel/meteorlake/fsp_params.c b/src/soc/intel/meteorlake/fsp_params.c index 0ae36e6..5bd28aa 100644 --- a/src/soc/intel/meteorlake/fsp_params.c +++ b/src/soc/intel/meteorlake/fsp_params.c @@ -32,6 +32,7 @@ #include <soc/ramstage.h> #include <soc/soc_chip.h> #include <soc/soc_info.h> +#include <static.h> #include <stdlib.h> #include <string.h> #include <types.h> diff --git a/src/soc/intel/meteorlake/pmc.c b/src/soc/intel/meteorlake/pmc.c index 5c4fa2c..837a8f3 100644 --- a/src/soc/intel/meteorlake/pmc.c +++ b/src/soc/intel/meteorlake/pmc.c @@ -15,6 +15,7 @@ #include <soc/pci_devs.h> #include <soc/pm.h> #include <soc/soc_chip.h> +#include <static.h> #include <stdint.h> #include <bootstate.h>
diff --git a/src/soc/intel/meteorlake/pmutil.c b/src/soc/intel/meteorlake/pmutil.c index 09fb46b..8e91b27 100644 --- a/src/soc/intel/meteorlake/pmutil.c +++ b/src/soc/intel/meteorlake/pmutil.c @@ -24,6 +24,7 @@ #include <soc/pm.h> #include <soc/smbus.h> #include <soc/soc_chip.h> +#include <static.h> #include <types.h>
/* diff --git a/src/soc/intel/meteorlake/romstage/fsp_params.c b/src/soc/intel/meteorlake/romstage/fsp_params.c index 917503e..bc7c20b 100644 --- a/src/soc/intel/meteorlake/romstage/fsp_params.c +++ b/src/soc/intel/meteorlake/romstage/fsp_params.c @@ -26,6 +26,7 @@ #include <soc/romstage.h> #include <soc/soc_chip.h> #include <soc/soc_info.h> +#include <static.h> #include <string.h> #include <ux_locales.h>
diff --git a/src/soc/intel/meteorlake/systemagent.c b/src/soc/intel/meteorlake/systemagent.c index 774a99f..bb841aa 100644 --- a/src/soc/intel/meteorlake/systemagent.c +++ b/src/soc/intel/meteorlake/systemagent.c @@ -12,6 +12,7 @@ #include <soc/iomap.h> #include <soc/soc_chip.h> #include <soc/systemagent.h> +#include <static.h>
/* * SoC implementation diff --git a/src/soc/intel/meteorlake/tcss.c b/src/soc/intel/meteorlake/tcss.c index 7509504..3d46f0a 100644 --- a/src/soc/intel/meteorlake/tcss.c +++ b/src/soc/intel/meteorlake/tcss.c @@ -2,6 +2,7 @@
#include <intelblocks/tcss.h> #include <soc/soc_chip.h> +#include <static.h>
const struct soc_tcss_ops tcss_ops = { .configure_aux_bias_pads = ioe_tcss_configure_aux_bias_pads_sbi, diff --git a/src/soc/intel/pantherlake/acpi.c b/src/soc/intel/pantherlake/acpi.c index c49555b..5df3ef9 100644 --- a/src/soc/intel/pantherlake/acpi.c +++ b/src/soc/intel/pantherlake/acpi.c @@ -20,6 +20,7 @@ #include <soc/pm.h> #include <soc/soc_chip.h> #include <soc/systemagent.h> +#include <static.h> #include <types.h>
/* diff --git a/src/soc/intel/pantherlake/chip.c b/src/soc/intel/pantherlake/chip.c index 2202878..61e00fa 100644 --- a/src/soc/intel/pantherlake/chip.c +++ b/src/soc/intel/pantherlake/chip.c @@ -24,6 +24,7 @@ #include <soc/ramstage.h> #include <soc/soc_chip.h> #include <soc/tcss.h> +#include <static.h>
#if CONFIG(HAVE_ACPI_TABLES) const char *soc_acpi_name(const struct device *dev) diff --git a/src/soc/intel/pantherlake/cpu.c b/src/soc/intel/pantherlake/cpu.c index 1b81856..9109263 100644 --- a/src/soc/intel/pantherlake/cpu.c +++ b/src/soc/intel/pantherlake/cpu.c @@ -20,6 +20,7 @@ #include <soc/msr.h> #include <soc/pci_devs.h> #include <soc/soc_chip.h> +#include <static.h>
bool cpu_soc_is_in_untrusted_mode(void) { diff --git a/src/soc/intel/pantherlake/espi.c b/src/soc/intel/pantherlake/espi.c index 02bec6f..d5b5cf9 100644 --- a/src/soc/intel/pantherlake/espi.c +++ b/src/soc/intel/pantherlake/espi.c @@ -13,6 +13,7 @@ #include <soc/pci_devs.h> #include <soc/pcr_ids.h> #include <soc/soc_chip.h> +#include <static.h>
void soc_get_gen_io_dec_range(uint32_t gen_io_dec[LPC_NUM_GENERIC_IO_RANGES]) { diff --git a/src/soc/intel/pantherlake/fsp_params.c b/src/soc/intel/pantherlake/fsp_params.c index 1c764fa..eaef582 100644 --- a/src/soc/intel/pantherlake/fsp_params.c +++ b/src/soc/intel/pantherlake/fsp_params.c @@ -16,6 +16,7 @@ #include <soc/intel/common/vbt.h> #include <soc/pcie.h> #include <soc/ramstage.h> +#include <static.h>
#define MAX_ONBOARD_PCIE_DEVICES 256
diff --git a/src/soc/intel/pantherlake/pmc.c b/src/soc/intel/pantherlake/pmc.c index 1c1ca5d..de6bf0c 100644 --- a/src/soc/intel/pantherlake/pmc.c +++ b/src/soc/intel/pantherlake/pmc.c @@ -15,6 +15,7 @@ #include <soc/pci_devs.h> #include <soc/pm.h> #include <soc/soc_chip.h> +#include <static.h> #include <stdint.h>
#define PMC_HID "INTC1026" diff --git a/src/soc/intel/pantherlake/pmutil.c b/src/soc/intel/pantherlake/pmutil.c index 892972c..888bb56 100644 --- a/src/soc/intel/pantherlake/pmutil.c +++ b/src/soc/intel/pantherlake/pmutil.c @@ -24,6 +24,7 @@ #include <soc/pm.h> #include <soc/smbus.h> #include <soc/soc_chip.h> +#include <static.h> #include <types.h>
/* diff --git a/src/soc/intel/pantherlake/romstage/fsp_params.c b/src/soc/intel/pantherlake/romstage/fsp_params.c index f6ba498..b105d3d 100644 --- a/src/soc/intel/pantherlake/romstage/fsp_params.c +++ b/src/soc/intel/pantherlake/romstage/fsp_params.c @@ -9,6 +9,7 @@ #include <soc/msr.h> #include <soc/pcie.h> #include <soc/romstage.h> +#include <static.h>
#define FSP_CLK_NOTUSED 0xff #define FSP_CLK_LAN 0x70 diff --git a/src/soc/intel/pantherlake/systemagent.c b/src/soc/intel/pantherlake/systemagent.c index 418f41c..e7a0701 100644 --- a/src/soc/intel/pantherlake/systemagent.c +++ b/src/soc/intel/pantherlake/systemagent.c @@ -12,6 +12,7 @@ #include <soc/iomap.h> #include <soc/soc_chip.h> #include <soc/systemagent.h> +#include <static.h>
/* * SoC implementation diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c index e0381e8..3a60ada 100644 --- a/src/soc/intel/skylake/acpi.c +++ b/src/soc/intel/skylake/acpi.c @@ -17,6 +17,7 @@ #include <soc/pm.h> #include <soc/ramstage.h> #include <soc/systemagent.h> +#include <static.h> #include <string.h> #include <types.h>
diff --git a/src/soc/intel/skylake/bootblock/pch.c b/src/soc/intel/skylake/bootblock/pch.c index cc2d384..df00bb8 100644 --- a/src/soc/intel/skylake/bootblock/pch.c +++ b/src/soc/intel/skylake/bootblock/pch.c @@ -18,6 +18,7 @@ #include <soc/pcr_ids.h> #include <soc/pm.h> #include <soc/pmc.h> +#include <static.h> #include "../chip.h"
#define PCR_DMI_ACPIBA 0x27B4 diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c index d1cc6f9..a6844e0 100644 --- a/src/soc/intel/skylake/chip.c +++ b/src/soc/intel/skylake/chip.c @@ -28,6 +28,7 @@ #include <soc/ramstage.h> #include <soc/systemagent.h> #include <soc/usb.h> +#include <static.h> #include <string.h> #include <types.h>
diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c index 057aece..8f294f7 100644 --- a/src/soc/intel/skylake/cpu.c +++ b/src/soc/intel/skylake/cpu.c @@ -21,6 +21,7 @@ #include <soc/pci_devs.h> #include <soc/ramstage.h> #include <soc/systemagent.h> +#include <static.h> #include <types.h>
#include "chip.h" diff --git a/src/soc/intel/skylake/fadt.c b/src/soc/intel/skylake/fadt.c index 693218f..5de44d3 100644 --- a/src/soc/intel/skylake/fadt.c +++ b/src/soc/intel/skylake/fadt.c @@ -3,6 +3,7 @@ #include <acpi/acpi.h> #include <soc/iomap.h> #include <soc/pm.h> +#include <static.h> #include "chip.h"
void soc_fill_fadt(acpi_fadt_t *fadt) diff --git a/src/soc/intel/skylake/lpc.c b/src/soc/intel/skylake/lpc.c index eea86fc..4b957df 100644 --- a/src/soc/intel/skylake/lpc.c +++ b/src/soc/intel/skylake/lpc.c @@ -10,6 +10,7 @@ #include <soc/iomap.h> #include <soc/pcr_ids.h> #include <soc/intel/common/block/lpc/lpc_def.h> +#include <static.h>
#include "chip.h"
diff --git a/src/soc/intel/skylake/pmc.c b/src/soc/intel/skylake/pmc.c index 71d1ef0..7c8d7c1 100644 --- a/src/soc/intel/skylake/pmc.c +++ b/src/soc/intel/skylake/pmc.c @@ -11,6 +11,7 @@ #include <intelblocks/rtc.h> #include <soc/pci_devs.h> #include <soc/pm.h> +#include <static.h>
#include "chip.h"
diff --git a/src/soc/intel/skylake/pmutil.c b/src/soc/intel/skylake/pmutil.c index 5152237..5e7d543 100644 --- a/src/soc/intel/skylake/pmutil.c +++ b/src/soc/intel/skylake/pmutil.c @@ -24,6 +24,7 @@ #include <soc/pmc.h> #include <soc/smbus.h> #include <security/vboot/vbnv.h> +#include <static.h>
#include "chip.h"
diff --git a/src/soc/intel/skylake/romstage/fsp_params.c b/src/soc/intel/skylake/romstage/fsp_params.c index f24054a..bd3d086 100644 --- a/src/soc/intel/skylake/romstage/fsp_params.c +++ b/src/soc/intel/skylake/romstage/fsp_params.c @@ -10,6 +10,7 @@ #include <soc/pci_devs.h> #include <soc/romstage.h> #include <soc/soc_chip.h> +#include <static.h>
static void cpu_flex_override(FSP_M_CONFIG *m_cfg) { diff --git a/src/soc/intel/skylake/systemagent.c b/src/soc/intel/skylake/systemagent.c index d203bda..3708f05 100644 --- a/src/soc/intel/skylake/systemagent.c +++ b/src/soc/intel/skylake/systemagent.c @@ -12,6 +12,7 @@ #include <soc/msr.h> #include <soc/pci_devs.h> #include <soc/systemagent.h> +#include <static.h> #include <types.h> #include "chip.h"
diff --git a/src/soc/intel/tigerlake/acpi.c b/src/soc/intel/tigerlake/acpi.c index c34b185..dd9ef73 100644 --- a/src/soc/intel/tigerlake/acpi.c +++ b/src/soc/intel/tigerlake/acpi.c @@ -19,6 +19,7 @@ #include <soc/pm.h> #include <soc/soc_chip.h> #include <soc/systemagent.h> +#include <static.h>
/* * List of supported C-states in this processor. diff --git a/src/soc/intel/tigerlake/bootblock/pch.c b/src/soc/intel/tigerlake/bootblock/pch.c index 64e8b2e..084bd7f 100644 --- a/src/soc/intel/tigerlake/bootblock/pch.c +++ b/src/soc/intel/tigerlake/bootblock/pch.c @@ -27,6 +27,7 @@ #include <soc/pci_devs.h> #include <soc/pcr_ids.h> #include <soc/pm.h> +#include <static.h>
#if CONFIG(SOC_INTEL_TIGERLAKE_PCH_H) #define PCR_PSF3_TO_SHDW_PMC_REG_BASE 0x1000 diff --git a/src/soc/intel/tigerlake/chip.c b/src/soc/intel/tigerlake/chip.c index f90f8ad..f2ccb48 100644 --- a/src/soc/intel/tigerlake/chip.c +++ b/src/soc/intel/tigerlake/chip.c @@ -16,6 +16,7 @@ #include <soc/pci_devs.h> #include <soc/ramstage.h> #include <soc/soc_chip.h> +#include <static.h>
#if CONFIG(HAVE_ACPI_TABLES) const char *soc_acpi_name(const struct device *dev) diff --git a/src/soc/intel/tigerlake/cpu.c b/src/soc/intel/tigerlake/cpu.c index 3d0f0e9..0c6f36e 100644 --- a/src/soc/intel/tigerlake/cpu.c +++ b/src/soc/intel/tigerlake/cpu.c @@ -20,6 +20,7 @@ #include <soc/msr.h> #include <soc/pci_devs.h> #include <soc/soc_chip.h> +#include <static.h> #include <types.h>
bool cpu_soc_is_in_untrusted_mode(void) diff --git a/src/soc/intel/tigerlake/espi.c b/src/soc/intel/tigerlake/espi.c index 6ef7c6d..3b56e29 100644 --- a/src/soc/intel/tigerlake/espi.c +++ b/src/soc/intel/tigerlake/espi.c @@ -20,6 +20,7 @@ #include <soc/pci_devs.h> #include <soc/pcr_ids.h> #include <soc/soc_chip.h> +#include <static.h>
void soc_get_gen_io_dec_range(uint32_t gen_io_dec[LPC_NUM_GENERIC_IO_RANGES]) { diff --git a/src/soc/intel/tigerlake/fsp_params.c b/src/soc/intel/tigerlake/fsp_params.c index fa95e47..c3400b4 100644 --- a/src/soc/intel/tigerlake/fsp_params.c +++ b/src/soc/intel/tigerlake/fsp_params.c @@ -27,6 +27,7 @@ #include <soc/ramstage.h> #include <soc/soc_chip.h> #include <soc/tcss.h> +#include <static.h> #include <string.h> #include <types.h>
diff --git a/src/soc/intel/tigerlake/pmc.c b/src/soc/intel/tigerlake/pmc.c index 0bba1a0..8912cb3 100644 --- a/src/soc/intel/tigerlake/pmc.c +++ b/src/soc/intel/tigerlake/pmc.c @@ -20,6 +20,7 @@ #include <soc/pci_devs.h> #include <soc/pm.h> #include <soc/soc_chip.h> +#include <static.h> #include <bootstate.h>
#define PMC_HID "INTC1026" diff --git a/src/soc/intel/tigerlake/pmutil.c b/src/soc/intel/tigerlake/pmutil.c index ba33e49..cd22942 100644 --- a/src/soc/intel/tigerlake/pmutil.c +++ b/src/soc/intel/tigerlake/pmutil.c @@ -30,6 +30,7 @@ #include <soc/smbus.h> #include <soc/soc_chip.h> #include <security/vboot/vbnv.h> +#include <static.h>
/* * SMI diff --git a/src/soc/intel/tigerlake/romstage/fsp_params.c b/src/soc/intel/tigerlake/romstage/fsp_params.c index 00b5315..5ebd46d 100644 --- a/src/soc/intel/tigerlake/romstage/fsp_params.c +++ b/src/soc/intel/tigerlake/romstage/fsp_params.c @@ -16,6 +16,7 @@ #include <soc/pci_devs.h> #include <soc/romstage.h> #include <soc/soc_chip.h> +#include <static.h> #include <string.h>
static void soc_memory_init_params(FSP_M_CONFIG *m_cfg, diff --git a/src/soc/intel/tigerlake/systemagent.c b/src/soc/intel/tigerlake/systemagent.c index 06282ea..143fd72 100644 --- a/src/soc/intel/tigerlake/systemagent.c +++ b/src/soc/intel/tigerlake/systemagent.c @@ -17,6 +17,7 @@ #include <soc/iomap.h> #include <soc/soc_chip.h> #include <soc/systemagent.h> +#include <static.h>
/* * SoC implementation diff --git a/src/soc/intel/xeon_sp/acpi.c b/src/soc/intel/xeon_sp/acpi.c index 8d74240..916e2df 100644 --- a/src/soc/intel/xeon_sp/acpi.c +++ b/src/soc/intel/xeon_sp/acpi.c @@ -9,6 +9,7 @@ #include <soc/pci_devs.h> #include <soc/util.h> #include <southbridge/intel/common/acpi_pirq_gen.h> +#include <static.h> #include <stdint.h> #include <stdio.h> #include <stdlib.h> diff --git a/src/soc/intel/xeon_sp/cpx/romstage.c b/src/soc/intel/xeon_sp/cpx/romstage.c index 2a85032..ffcb052 100644 --- a/src/soc/intel/xeon_sp/cpx/romstage.c +++ b/src/soc/intel/xeon_sp/cpx/romstage.c @@ -13,6 +13,7 @@ #include <soc/pci_devs.h> #include <soc/intel/common/smbios.h> #include <soc/soc_util.h> +#include <static.h> #include <string.h>
#include "chip.h" diff --git a/src/soc/intel/xeon_sp/lpc.c b/src/soc/intel/xeon_sp/lpc.c index bf1dedd..1b44ddd 100644 --- a/src/soc/intel/xeon_sp/lpc.c +++ b/src/soc/intel/xeon_sp/lpc.c @@ -4,6 +4,7 @@ #include <intelblocks/lpc_lib.h> #include <soc/iomap.h> #include <soc/pcr_ids.h> +#include <static.h>
#include <chip.h>
diff --git a/src/soc/intel/xeon_sp/skx/romstage.c b/src/soc/intel/xeon_sp/skx/romstage.c index 4a8c6b0..21b3522 100644 --- a/src/soc/intel/xeon_sp/skx/romstage.c +++ b/src/soc/intel/xeon_sp/skx/romstage.c @@ -4,6 +4,7 @@ #include <intelblocks/rtc.h> #include <soc/romstage.h> #include <soc/soc_util.h> +#include <static.h>
#include "chip.h"
diff --git a/src/soc/intel/xeon_sp/spr/romstage.c b/src/soc/intel/xeon_sp/spr/romstage.c index 4d95a33..4438a59 100644 --- a/src/soc/intel/xeon_sp/spr/romstage.c +++ b/src/soc/intel/xeon_sp/spr/romstage.c @@ -18,6 +18,7 @@ #include <soc/romstage.h> #include <soc/pci_devs.h> #include <soc/soc_pch.h> +#include <static.h> #include <string.h> #include <soc/config.h> #include <soc/soc_util.h>