Attention is currently required from: Martin Roth, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78220?usp=email )
Change subject: soc/amd/genoa: Add GPIO definitions ......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/genoa/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/78220/comment/c2e0bca1_4d6da623 : PS4, Line 108: #define GPIO_0_IOMUX_GPIO_PU1PD0 1 : #define GPIO_0_IOMUX_GPIO 2 the mux setting to be used for gpio for this pin needs to be GPIO_0_IOMUX_GPIOxx to match the define name that gets generated when using a gpio pad macro for gpio 0. not exactly sure which one of those two that should be though; probably the one for the mux setting 2