Bill XIE has posted comments on this change. ( https://review.coreboot.org/29434 )
Change subject: mb/lenovo/x220: Add x1 as a variant ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x1.md File Documentation/mainboard/lenovo/x1.md:
https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x1.md... PS4, Line 9: cable (already detached from MB in the picture) connecting the keyboard
No picture ?
A picture is added in the newest revision.
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... File src/mainboard/lenovo/x220/variants/x1/devicetree.cb:
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 104:
in that case you have three unused enabled pcie slots, which should be set to "off".
Unused pci-e ports are set to off in the newest revision.
-
Bill XIE (Code Review)