Attention is currently required from: Eran Mitrani, Subrata Banik, Kapil Porwal.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 )
Change subject: soc/intel/{adl, common}: provide a list of D-states to enter LPM
......................................................................
Patch Set 12:
(1 comment)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/c78e82d9_b01edea5
PS9, Line 31: LPI_REVISION_0
I removed the explicit values per Subrata's comment..
imho, I think it's important to have them incase anyone ever adds other things. In these cases, these values have specific meanings (values) in the specification and if someone inserts something, we could now be sending across the wrong values.
@subrata, wdyt?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70166
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Gerrit-Change-Number: 70166
Gerrit-PatchSet: 12
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Fri, 02 Dec 2022 21:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Eran Mitrani
mitrani@google.com
Gerrit-MessageType: comment