HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46181 )
Change subject: mb/google/zork: Convert to ASL 2.0 syntax ......................................................................
mb/google/zork: Convert to ASL 2.0 syntax
Change-Id: I71ee54116ade4d6826dffc31ee879a70d3fc967f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl 1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/46181/1
diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl index 8f5aa6a..8576d12 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl @@ -21,10 +21,10 @@ /* Convert from Degrees C to 1/10 Kelvin for ACPI */ Method (CTOK, 1) { /* 10th of Degrees C */ - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10
/* Convert to Kelvin */ - Add (Local0, 2732, Local0) + Local0 += 2732
Return (Local0) } @@ -50,23 +50,23 @@ Method (_TMP, 0, Serialized) { /* Get temperature from EC in deci-kelvin */ - Store (_SB.PCI0.LPCB.EC0.TSRD (TMPS), Local0) + Local0 =_SB.PCI0.LPCB.EC0.TSRD (TMPS)
/* Critical temperature in deci-kelvin */ - Store (CTOK (\TCRT), Local1) + Local1 = CTOK (\TCRT)
- If (LGreaterEqual (Local0, Local1)) { - Store ("CRITICAL TEMPERATURE", Debug) - Store (Local0, Debug) + If (Local0 >= Local1) { + Debug = "CRITICAL TEMPERATURE" + Debug = Local0
/* Wait 1 second for EC to re-poll */ Sleep (1000)
/* Re-read temperature from EC */ - Store (_SB.PCI0.LPCB.EC0.TSRD (TMPS), Local0) + Local0 =_SB.PCI0.LPCB.EC0.TSRD (TMPS)
- Store ("RE-READ TEMPERATURE", Debug) - Store (Local0, Debug) + Debug = "RE-READ TEMPERATURE" + Debug = Local0 }
Return (Local0)
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46181 )
Change subject: mb/google/zork: Convert to ASL 2.0 syntax ......................................................................
Patch Set 1:
(1 comment)
Hey, thanks for doing all this conversion. It does make it easier to read.
https://review.coreboot.org/c/coreboot/+/46181/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl:
https://review.coreboot.org/c/coreboot/+/46181/1/src/mainboard/google/zork/v... PS1, Line 53: =\ Is there a reason that there's no space here and in the same change below?
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46181
to look at the new patch set (#2).
Change subject: mb/google/zork: Convert to ASL 2.0 syntax ......................................................................
mb/google/zork: Convert to ASL 2.0 syntax
Change-Id: I71ee54116ade4d6826dffc31ee879a70d3fc967f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl 1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/46181/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46181 )
Change subject: mb/google/zork: Convert to ASL 2.0 syntax ......................................................................
Patch Set 2:
(1 comment)
You are welcome.
Thanks.
https://review.coreboot.org/c/coreboot/+/46181/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl:
https://review.coreboot.org/c/coreboot/+/46181/1/src/mainboard/google/zork/v... PS1, Line 53: =\
Is there a reason that there's no space here and in the same change below?
Oops :) fixed also for google/kahlee
Thank you
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46181 )
Change subject: mb/google/zork: Convert to ASL 2.0 syntax ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46181 )
Change subject: mb/google/zork: Convert to ASL 2.0 syntax ......................................................................
mb/google/zork: Convert to ASL 2.0 syntax
Change-Id: I71ee54116ade4d6826dffc31ee879a70d3fc967f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46181 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl 1 file changed, 10 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl index 8f5aa6a..dec33ec 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl @@ -21,10 +21,10 @@ /* Convert from Degrees C to 1/10 Kelvin for ACPI */ Method (CTOK, 1) { /* 10th of Degrees C */ - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10
/* Convert to Kelvin */ - Add (Local0, 2732, Local0) + Local0 += 2732
Return (Local0) } @@ -50,23 +50,23 @@ Method (_TMP, 0, Serialized) { /* Get temperature from EC in deci-kelvin */ - Store (_SB.PCI0.LPCB.EC0.TSRD (TMPS), Local0) + Local0 = _SB.PCI0.LPCB.EC0.TSRD (TMPS)
/* Critical temperature in deci-kelvin */ - Store (CTOK (\TCRT), Local1) + Local1 = CTOK (\TCRT)
- If (LGreaterEqual (Local0, Local1)) { - Store ("CRITICAL TEMPERATURE", Debug) - Store (Local0, Debug) + If (Local0 >= Local1) { + Debug = "CRITICAL TEMPERATURE" + Debug = Local0
/* Wait 1 second for EC to re-poll */ Sleep (1000)
/* Re-read temperature from EC */ - Store (_SB.PCI0.LPCB.EC0.TSRD (TMPS), Local0) + Local0 = _SB.PCI0.LPCB.EC0.TSRD (TMPS)
- Store ("RE-READ TEMPERATURE", Debug) - Store (Local0, Debug) + Debug = "RE-READ TEMPERATURE" + Debug = Local0 }
Return (Local0)
-
HAOUAS Elyes (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)