Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
mb/google/zork: Convert to ASL 2.0 syntax

Change-Id: I71ee54116ade4d6826dffc31ee879a70d3fc967f
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46181
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
---
M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl
1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl
index 8f5aa6a..dec33ec 100644
--- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl
+++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl
@@ -21,10 +21,10 @@
/* Convert from Degrees C to 1/10 Kelvin for ACPI */
Method (CTOK, 1) {
/* 10th of Degrees C */
- Multiply (Arg0, 10, Local0)
+ Local0 = Arg0 * 10

/* Convert to Kelvin */
- Add (Local0, 2732, Local0)
+ Local0 += 2732

Return (Local0)
}
@@ -50,23 +50,23 @@
Method (_TMP, 0, Serialized)
{
/* Get temperature from EC in deci-kelvin */
- Store (\_SB.PCI0.LPCB.EC0.TSRD (TMPS), Local0)
+ Local0 = \_SB.PCI0.LPCB.EC0.TSRD (TMPS)

/* Critical temperature in deci-kelvin */
- Store (CTOK (\TCRT), Local1)
+ Local1 = CTOK (\TCRT)

- If (LGreaterEqual (Local0, Local1)) {
- Store ("CRITICAL TEMPERATURE", Debug)
- Store (Local0, Debug)
+ If (Local0 >= Local1) {
+ Debug = "CRITICAL TEMPERATURE"
+ Debug = Local0

/* Wait 1 second for EC to re-poll */
Sleep (1000)

/* Re-read temperature from EC */
- Store (\_SB.PCI0.LPCB.EC0.TSRD (TMPS), Local0)
+ Local0 = \_SB.PCI0.LPCB.EC0.TSRD (TMPS)

- Store ("RE-READ TEMPERATURE", Debug)
- Store (Local0, Debug)
+ Debug = "RE-READ TEMPERATURE"
+ Debug = Local0
}

Return (Local0)

To view, visit change 46181. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71ee54116ade4d6826dffc31ee879a70d3fc967f
Gerrit-Change-Number: 46181
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged