[S] Change in coreboot[master]: acpi: Add missing cbfs_unmap() - coreboot-gerrit

24 Apr 2023


      Attention is currently required from: Lance Zhao, Konrad Adamczyk, Tim Wawrzynczak, Grzegorz Bernacki, Tim Van Patten, Karthik Ramasubramanian.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74715 )
Change subject: acpi: Add missing cbfs_unmap()
......................................................................
Patch Set 1:
(2 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/74715/comment/ab49046b_ff49e191 
PS1, Line 1860: slic_file = cbfs_map(CONFIG_CBFS_PREFIX "/slic", &slic_size);
I think SLIC also should get unmapped.
https://review.coreboot.org/c/coreboot/+/74715/comment/008e40fb_028726d9 
PS1, Line 1951: acpi_add_table(rsdp, slic);
+ `cbfs_unmap(slic_file);`
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74715
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf7ba6842f42404ad8bb415f8e7fda10403cbe2e
Gerrit-Change-Number: 74715
Gerrit-PatchSet: 1
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Konrad Adamczyk konrada@google.com
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Konrad Adamczyk konrada@google.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Mon, 24 Apr 2023 12:34:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment