Attention is currently required from: Wonkyu Kim, Subrata Banik, Kangheui Won, Paul Menzel, Rizwan Qureshi, Tim Wawrzynczak, Meera Ravindranath.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62856 )
Change subject: soc/intel/alderlake: Add support for UFS controller
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62856/comment/b0846c1b_b6fc1a01
PS1, Line 8:
Add an introduction saying what UFS controller does, and where it’s documented?
AIUI, UFS is the successor of eMMC
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/62856/comment/e460fc17_29af6021
PS2, Line 620: /* UFS */
Can you use is_devfn_enabled function like below?
s_cfg->UfsEnable[1] = is_devfn_enabled(PCH_DEVFN_UFS);
This would also work, yes.
s_cfg->UfsEnable[0] is not used?
I think UFS-0 is PCI D18:F5 (0:12.5 in hex) and UFS-1 is PCI D18:F7 (0:12.7 in hex). I have no idea why UFS-0 is unused. I only see balls for one UFS controller in the datasheet.
BTW, looks like document 691222-001 has a typo, it says UFS is PCI D18:F0, but that's actually ISH: https://imgur.com/AiA2TL8.png
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62856
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92f024ded64e1eaef41a7807133361d74b5009d4
Gerrit-Change-Number: 62856
Gerrit-PatchSet: 2
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniil Lunev
dlunev@chromium.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Comment-Date: Sun, 03 Apr 2022 12:24:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment