Attention is currently required from: Bora Guvendik, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kane Chen, Kapil Porwal, Matt Chen, Subrata Banik, Tarun, Wonkyu Kim.
Hello Bora Guvendik, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kane Chen, Kapil Porwal, Matt Chen, Subrata Banik, Tarun, Wonkyu Kim, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78122?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/rex: Turn off CNVi 3.3v power at romstage
......................................................................
mb/google/rex: Turn off CNVi 3.3v power at romstage
Turn CNVi 3.3v off at romstage so that it will be toggled during warm
boot. Cnvi 3.3v is already turned on at ramstage. This is necessary
to ensure the device starts in clean state.
BUG=286187821
BUG=297293441
TEST= Check the Cnvi is enumerated after warm reboot.
Signed-off-by: Cliff Huang cliff.huang@intel.com
Change-Id: I2f1bfc9f41bcb56c2a8af83ef75f3fab42e060f0
---
M src/mainboard/google/rex/variants/karis/gpio.c
M src/mainboard/google/rex/variants/ovis/gpio.c
M src/mainboard/google/rex/variants/rex0/gpio.c
M src/mainboard/google/rex/variants/screebo/gpio.c
4 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/78122/3
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78122?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f1bfc9f41bcb56c2a8af83ef75f3fab42e060f0
Gerrit-Change-Number: 78122
Gerrit-PatchSet: 3
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-MessageType: newpatchset