HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32898
Change subject: soc/intel/fsp_broadwell_de/romstage: Remove variable set but not used ......................................................................
soc/intel/fsp_broadwell_de/romstage: Remove variable set but not used
Change-Id: I3e304b9b19978c4100ef3486088d809c2a7fe1d7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/fsp_broadwell_de/romstage/romstage.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/32898/1
diff --git a/src/soc/intel/fsp_broadwell_de/romstage/romstage.c b/src/soc/intel/fsp_broadwell_de/romstage/romstage.c index a75dabd..e929fa4 100644 --- a/src/soc/intel/fsp_broadwell_de/romstage/romstage.c +++ b/src/soc/intel/fsp_broadwell_de/romstage/romstage.c @@ -93,7 +93,6 @@ */ void romstage_main_continue(EFI_STATUS status, void *hob_list_ptr) { - int cbmem_was_initted; void *cbmem_hob_ptr;
post_code(0x4a); @@ -112,7 +111,7 @@ late_mainboard_romstage_entry();
post_code(0x4d); - cbmem_was_initted = !cbmem_recovery(0); + cbmem_recovery(0);
/* Save the HOB pointer in CBMEM to be used in ramstage*/ cbmem_hob_ptr = cbmem_add(CBMEM_ID_HOB_POINTER, sizeof(*hob_list_ptr));
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32898 )
Change subject: soc/intel/fsp_broadwell_de/romstage: Remove variable set but not used ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32898 )
Change subject: soc/intel/fsp_broadwell_de/romstage: Remove variable set but not used ......................................................................
soc/intel/fsp_broadwell_de/romstage: Remove variable set but not used
Change-Id: I3e304b9b19978c4100ef3486088d809c2a7fe1d7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32898 Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/fsp_broadwell_de/romstage/romstage.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/soc/intel/fsp_broadwell_de/romstage/romstage.c b/src/soc/intel/fsp_broadwell_de/romstage/romstage.c index 121cb25..38cd947 100644 --- a/src/soc/intel/fsp_broadwell_de/romstage/romstage.c +++ b/src/soc/intel/fsp_broadwell_de/romstage/romstage.c @@ -94,7 +94,6 @@ */ void romstage_main_continue(EFI_STATUS status, void *hob_list_ptr) { - int cbmem_was_initted; void *cbmem_hob_ptr;
post_code(0x4a); @@ -113,7 +112,7 @@ late_mainboard_romstage_entry();
post_code(0x4d); - cbmem_was_initted = !cbmem_recovery(0); + cbmem_recovery(0);
/* Save the HOB pointer in CBMEM to be used in ramstage*/ cbmem_hob_ptr = cbmem_add(CBMEM_ID_HOB_POINTER, sizeof(*hob_list_ptr));