Change in ...coreboot[master]: soc/intel/fsp_baytrail/romstage: Remove variable set but not used

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32899

Change subject: soc/intel/fsp_baytrail/romstage: Remove variable set but not used
......................................................................

soc/intel/fsp_baytrail/romstage: Remove variable set but not used

Change-Id: Ic04cb7c51862bea4d01f853ee2c88cc03c414e35
Signed-off-by: Elyes HAOUAS 
---
M src/soc/intel/fsp_baytrail/romstage/romstage.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/32899/1

diff --git a/src/soc/intel/fsp_baytrail/romstage/romstage.c b/src/soc/intel/fsp_baytrail/romstage/romstage.c
index c46b09e..b26e696 100644
--- a/src/soc/intel/fsp_baytrail/romstage/romstage.c
+++ b/src/soc/intel/fsp_baytrail/romstage/romstage.c
@@ -217,7 +217,6 @@
  */
 void romstage_main_continue(EFI_STATUS status, void *hob_list_ptr)
 {
-	int cbmem_was_initted;
    void *cbmem_hob_ptr;
    uint32_t prev_sleep_state;

@@ -244,7 +243,7 @@
    late_mainboard_romstage_entry();
    post_code(0x4c);

-	cbmem_was_initted = !cbmem_recovery(prev_sleep_state == ACPI_S3);
+	cbmem_recovery(prev_sleep_state == ACPI_S3);

/* Save the HOB pointer in CBMEM to be used in ramstage*/
    cbmem_hob_ptr = cbmem_add(CBMEM_ID_HOB_POINTER, sizeof(*hob_list_ptr));

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32899 )

Change subject: soc/intel/fsp_baytrail/romstage: Remove variable set but not used
......................................................................

Patch Set 3: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32899 )

Change subject: soc/intel/fsp_baytrail/romstage: Remove variable set but not used
......................................................................

soc/intel/fsp_baytrail/romstage: Remove variable set but not used

Change-Id: Ic04cb7c51862bea4d01f853ee2c88cc03c414e35
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32899
Reviewed-by: Patrick Georgi 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/fsp_baytrail/romstage/romstage.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

diff --git a/src/soc/intel/fsp_baytrail/romstage/romstage.c b/src/soc/intel/fsp_baytrail/romstage/romstage.c
index 030b5df..52f4dc9 100644
--- a/src/soc/intel/fsp_baytrail/romstage/romstage.c
+++ b/src/soc/intel/fsp_baytrail/romstage/romstage.c
@@ -218,7 +218,6 @@
  */
 void romstage_main_continue(EFI_STATUS status, void *hob_list_ptr)
 {
-	int cbmem_was_initted;
    void *cbmem_hob_ptr;
    uint32_t prev_sleep_state;

@@ -245,7 +244,7 @@
    late_mainboard_romstage_entry();
    post_code(0x4c);

-	cbmem_was_initted = !cbmem_recovery(prev_sleep_state == ACPI_S3);
+	cbmem_recovery(prev_sleep_state == ACPI_S3);

/* Save the HOB pointer in CBMEM to be used in ramstage*/
    cbmem_hob_ptr = cbmem_add(CBMEM_ID_HOB_POINTER, sizeof(*hob_list_ptr));