Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37318 )
Change subject: coreboot: google/grunt: add G2 TS support ......................................................................
coreboot: google/grunt: add G2 TS support
Add G2 GTCH7503 HID TS support
BUG=b:141577276 BRANCH=master TEST=emerge-grunt coreboot
Change-Id: I91e4f2b934b64b14bca20108037b721288d40942 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/kahlee/variants/careena/devicetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/37318/1
diff --git a/src/mainboard/google/kahlee/variants/careena/devicetree.cb b/src/mainboard/google/kahlee/variants/careena/devicetree.cb index 635b237..3387b6f 100644 --- a/src/mainboard/google/kahlee/variants/careena/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/careena/devicetree.cb @@ -167,5 +167,19 @@ register "has_power_resource" = "1" device i2c 10 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GTCH7503"" + register "generic.desc" = ""G2TOUCH Touchscreen"" + register "generic.probed" = "1" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_11)" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_85)" + register "generic.reset_delay_ms" = "50" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)" + register "generic.enable_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 40 on end + end end end #chip soc/amd/stoneyridge
Hello build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37318
to look at the new patch set (#2).
Change subject: google/grunt: add G2 TS support ......................................................................
google/grunt: add G2 TS support
Add G2 GTCH7503 HID TS support
BUG=b:141577276 BRANCH=master TEST=emerge-grunt coreboot
Change-Id: I91e4f2b934b64b14bca20108037b721288d40942 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/kahlee/variants/careena/devicetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/37318/2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37318 )
Change subject: google/grunt: add G2 TS support ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37318 )
Change subject: google/grunt: add G2 TS support ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37318/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37318/2//COMMIT_MSG@7 PS2, Line 7: google/grunt: add G2 TS support I thought the Chromium folks used a different prefix scheme for variants.
https://review.coreboot.org/c/coreboot/+/37318/2//COMMIT_MSG@9 PS2, Line 9: Add G2 GTCH7503 HID TS support Please mention the source for the used values, like data sheet name and revision.
Hello Kevin Chiu, build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37318
to look at the new patch set (#3).
Change subject: mainboard/google/kahlee: add G2 TS support for careena ......................................................................
mainboard/google/kahlee: add G2 TS support for careena
Add G2 GTCH7503 HID TS support spec from G2: G7500 / Ver.1.2 (3, April, 2018)
BUG=b:141577276 BRANCH=master TEST=emerge-grunt coreboot
Change-Id: I91e4f2b934b64b14bca20108037b721288d40942 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/kahlee/variants/careena/devicetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/37318/3
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37318 )
Change subject: mainboard/google/kahlee: add G2 TS support for careena ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37318/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37318/2//COMMIT_MSG@7 PS2, Line 7: google/grunt: add G2 TS support
I thought the Chromium folks used a different prefix scheme for variants.
Done
https://review.coreboot.org/c/coreboot/+/37318/2//COMMIT_MSG@9 PS2, Line 9: Add G2 GTCH7503 HID TS support
Please mention the source for the used values, like data sheet name and revision.
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37318 )
Change subject: mainboard/google/kahlee: add G2 TS support for careena ......................................................................
mainboard/google/kahlee: add G2 TS support for careena
Add G2 GTCH7503 HID TS support spec from G2: G7500 / Ver.1.2 (3, April, 2018)
BUG=b:141577276 BRANCH=master TEST=emerge-grunt coreboot
Change-Id: I91e4f2b934b64b14bca20108037b721288d40942 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37318 Reviewed-by: Martin Roth martinroth@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kahlee/variants/careena/devicetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/variants/careena/devicetree.cb b/src/mainboard/google/kahlee/variants/careena/devicetree.cb index 635b237..3387b6f 100644 --- a/src/mainboard/google/kahlee/variants/careena/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/careena/devicetree.cb @@ -167,5 +167,19 @@ register "has_power_resource" = "1" device i2c 10 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GTCH7503"" + register "generic.desc" = ""G2TOUCH Touchscreen"" + register "generic.probed" = "1" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_11)" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_85)" + register "generic.reset_delay_ms" = "50" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)" + register "generic.enable_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 40 on end + end end end #chip soc/amd/stoneyridge
-
Kevin Chiu (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)