Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44212 )
Change subject: cpu/intel/model_2065x/Makefile.inc: Order entries ......................................................................
cpu/intel/model_2065x/Makefile.inc: Order entries
Group lines by stages, then subdirs, then microcode. Within groups, order in ascending count of `../` in prefix and then alphabetically.
Tested with BUILD_TIMELESS=1, Packard Bell MS2290 remains identical.
Change-Id: I33a1624b3714200262c412a066218dab1fca4e51 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/model_2065x/Makefile.inc 1 file changed, 22 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/44212/1
diff --git a/src/cpu/intel/model_2065x/Makefile.inc b/src/cpu/intel/model_2065x/Makefile.inc index 1428421..72ed621 100644 --- a/src/cpu/intel/model_2065x/Makefile.inc +++ b/src/cpu/intel/model_2065x/Makefile.inc @@ -1,24 +1,27 @@ -ramstage-y += model_2065x_init.c -subdirs-y += ../../x86/name -subdirs-y += ../../x86/cache -subdirs-y += ../../x86/mtrr -subdirs-y += ../../x86/lapic -subdirs-y += ../../x86/tsc -subdirs-y += ../../intel/turbo -subdirs-y += ../../intel/microcode -subdirs-y += ../../x86/smm -subdirs-y += ../smm/gen1 - -ramstage-y += acpi.c - -smm-y += finalize.c - -cpu_microcode_bins += $(wildcard 3rdparty/intel-microcode/intel-ucode/06-25-*) - -bootblock-y += ../car/non-evict/cache_as_ram.S bootblock-y += ../car/bootblock.c +bootblock-y += ../car/non-evict/cache_as_ram.S bootblock-y += ../../x86/early_reset.S
+romstage-y += ../car/romstage.c + postcar-y += ../car/non-evict/exit_car.S
-romstage-y += ../car/romstage.c +ramstage-y += acpi.c +ramstage-y += model_2065x_init.c + +smm-y += finalize.c + +subdirs-y += ../microcode +subdirs-y += ../smm/gen1 +subdirs-y += ../turbo +subdirs-y += ../../x86/cache +subdirs-y += ../../x86/lapic +subdirs-y += ../../x86/mtrr +subdirs-y += ../../x86/name +subdirs-y += ../../x86/smm +subdirs-y += ../../x86/tsc + +cpu_microcode_bins += $(wildcard 3rdparty/intel-microcode/intel-ucode/06-25-*) + + +
Hello Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44212
to look at the new patch set (#2).
Change subject: cpu/intel/model_2065x/Makefile.inc: Order entries ......................................................................
cpu/intel/model_2065x/Makefile.inc: Order entries
Group lines by stages, then subdirs, then microcode. Within groups, order in ascending count of `../` in prefix and then alphabetically. Also flatten some unneeded `../intel/` in paths for consistency.
Tested with BUILD_TIMELESS=1, Packard Bell MS2290 remains identical.
Change-Id: I33a1624b3714200262c412a066218dab1fca4e51 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/model_2065x/Makefile.inc 1 file changed, 22 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/44212/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44212
to look at the new patch set (#3).
Change subject: cpu/intel/model_2065x/Makefile.inc: Order entries ......................................................................
cpu/intel/model_2065x/Makefile.inc: Order entries
Group lines by stages, then subdirs, then microcode. Within groups, order in ascending count of `../` in prefix and then alphabetically. Also flatten some unneeded `../intel/` in paths for consistency.
Tested with BUILD_TIMELESS=1, Packard Bell MS2290 remains identical.
Change-Id: I33a1624b3714200262c412a066218dab1fca4e51 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/model_2065x/Makefile.inc 1 file changed, 19 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/44212/3
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44212 )
Change subject: cpu/intel/model_2065x/Makefile.inc: Order entries ......................................................................
Abandoned
Sorry, I ran out of patience and energy to care about these changes any longer.
-
Angel Pons (Code Review)