build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29065 )
Change subject: cpu/amd: Use common AMD's MSR ......................................................................
Patch Set 23:
(5 comments)
https://review.coreboot.org/#/c/29065/23/src/cpu/amd/family_10h-family_15h/d... File src/cpu/amd/family_10h-family_15h/defaults.h:
https://review.coreboot.org/#/c/29065/23/src/cpu/amd/family_10h-family_15h/d... PS23, Line 77: { NB_CFG_MSR, (AMD_FAM10_ALL | AMD_FAM15_ALL), AMD_PTYPE_DC | AMD_PTYPE_MC, line over 80 characters
https://review.coreboot.org/#/c/29065/23/src/cpu/amd/family_10h-family_15h/d... PS23, Line 107: 1 << 21, 0x00000000 }, /* Erratum #254 DR B1 BU_CFG_MSR[21]=1 */ line over 80 characters
https://review.coreboot.org/#/c/29065/23/src/cpu/amd/family_10h-family_15h/d... PS23, Line 118: { CPU_ID_FEATURES_MSR, (AMD_FAM10_ALL | AMD_FAM15_ALL), AMD_PTYPE_DC | AMD_PTYPE_MC, line over 80 characters
https://review.coreboot.org/#/c/29065/23/src/cpu/amd/family_10h-family_15h/f... File src/cpu/amd/family_10h-family_15h/fidvid.c:
https://review.coreboot.org/#/c/29065/23/src/cpu/amd/family_10h-family_15h/f... PS23, Line 660: && (!(rdmsr(PSTATE_1_MSR).lo & NB_DID_M_ON)) ) ? space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/29065/23/src/cpu/amd/family_10h-family_15h/p... File src/cpu/amd/family_10h-family_15h/powernow_acpi.c:
https://review.coreboot.org/#/c/29065/23/src/cpu/amd/family_10h-family_15h/p... PS23, Line 272: *(((uint8_t *)pcontrol_blk) + 0x04) = (rdmsr(MSR_CSTATE_ADDRESS).lo + 1) & 0xff; line over 80 characters