Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49140 )
Change subject: soc/intel/skylake/acpi: Add PEP table ......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49140/comment/bf8dd384_36775c4c PS3, Line 11:
Hmmm... just curious, what kernel version exactly? There was some fix recently that should be in mainline or maybe even stable.
I've been using 5.7.17, but it's the source code of 5.11.0-rc7 and master that I looked at.
Commit Message:
https://review.coreboot.org/c/coreboot/+/49140/comment/dd744f8c_6bf51958 PS5, Line 9:
maybe add "It is required to make the kernel load `intel_pmc_core`. […]
Done, thanks.
https://review.coreboot.org/c/coreboot/+/49140/comment/aaddb14e_115b92b5 PS5, Line 13: predictably.
... via debugfs.
Done
-
Benjamin Doron (Code Review)