Change in coreboot[master]: soc/intel/cannonlake: Configure GPIOs again after FSP-S is done

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31250 )

Change subject: soc/intel/cannonlake: Configure GPIOs again after FSP-S is done
......................................................................

Patch Set 5:

(1 comment)

Patchset:

PS5:
> Ugh.. I think it would be better to have FSP<->coreboot work in a more synchronized fashion than having to actively prevent what the other is doing.

Well, tell that Intel... I too don't like to have to hack around FSP but Intel doesn't really care in many cases it seems.
> Locking down the padcfg will lead to other side-effects as well -- payloads, OS would run into issues trying to reconfigure pads, which won't be acceptable.

Padcfg gets locked down by FSP anyways before any payload / OS starts.
> Are you seeing cases where the FSP is still configuring GPIOs it should not?

Well, as already mentioned, see CB:45211. All these UPDs will change pad config.