Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29662 )
Change subject: soc/intel/braswell: Add C_ENVIRONMENT_BOOTBLOCK support ......................................................................
Patch Set 2:
(2 comments)
I don't see where C_ENVIRONMENT_BOOTBLOCK is selected. Is it part of another commit ?
https://review.coreboot.org/#/c/29662/2/src/soc/intel/braswell/include/soc/b... File src/soc/intel/braswell/include/soc/bootblock.h:
https://review.coreboot.org/#/c/29662/2/src/soc/intel/braswell/include/soc/b... PS2, Line 18: obsolete file. should be removed.
https://review.coreboot.org/#/c/29662/2/src/soc/intel/braswell/romstage/car_... File src/soc/intel/braswell/romstage/car_stage.S:
https://review.coreboot.org/#/c/29662/2/src/soc/intel/braswell/romstage/car_... PS2, Line 23: call romstage_c_entry please replace romstage_c_entry with car_stage_entry of all affected mainboards and get rid of this file
-
Patrick Rudolph (Code Review)