Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 )
Change subject: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs
......................................................................
Patch Set 47:
After discussing with Philipp and Patrick G (from Google), it appears that there is no legal issue as such between CB<->FSP back-and-forth call to satisfy MP service requirement.
"So while we didn't get actual legal advice, the general opinion was that the calling back isn't an additional problem." - Patrick G
As legal issue is resolved now. I have further question for
@Ron/Philipp/Nico:
Do you have only concern with making use of EFI datatypes ? if so, we can think about something like below https://github.com/u-boot/u-boot/blob/master/include/efi_api.h
The reason, i'm still running behind this CL is that, we have few feature implementation pending without this CL. let me know your further concern.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25634
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956
Gerrit-Change-Number: 25634
Gerrit-PatchSet: 47
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Comment-Date: Wed, 20 Feb 2019 04:36:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment