Attention is currently required from: Jason Nien, Eric Lai, Martin Roth.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73294 )
Change subject: mb/google/skyrim: Allow port descriptors to be overridden ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/skyrim/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/73294/comment/28078bfb_81577d66 PS1, Line 99: *dxio_descs = skyrim_mdn_dxio_descriptors;
just curious, why don't we return skyrim_mdn_dxio_descriptors in weak function like gpio table do?
Maybe point me to what you're talking about? The overrides for GPIOs are returned by a weak function, but the baseboard doesn't return its GPIO tables in that function, it returns 0 because it has nothing to override.
Beyond that, my opinion is that the default for weak functions should always be to not do anything. If you have a default, handle it this way, checking to see if the weak function returned anything.