Attention is currently required from: Jason Nien, Eric Lai, Martin Roth.

View Change

1 comment:

• File src/mainboard/google/skyrim/port_descriptors.c:

  • Patch Set #1, Line 99: *dxio_descs = skyrim_mdn_dxio_descriptors;

    just curious, why don't we return skyrim_mdn_dxio_descriptors in weak function like gpio table do?

    Maybe point me to what you're talking about? The overrides for GPIOs are returned by a weak function, but the baseboard doesn't return its GPIO tables in that function, it returns 0 because it has nothing to override.

    Beyond that, my opinion is that the default for weak functions should always be to not do anything. If you have a default, handle it this way, checking to see if the weak function returned anything.

To view, visit change 73294. To unsubscribe, or for help writing mail filters, visit settings.