Change in coreboot[master]: x86/acpigen: Deprecat use of 'Processor()'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: x86/acpigen: Deprecat use of 'Processor()'
......................................................................

x86/acpigen: Deprecat use of 'Processor()'

Processor() operator is deprecated, use Device() instead.

Change-Id: Ic9ea2ed6a2128dc4fe94155d098c2a4f7c24d82f
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/acpigen.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/37876/1

diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c
index cc724a0..d4536cf 100644
--- a/src/arch/x86/acpigen.c
+++ b/src/arch/x86/acpigen.c
@@ -332,6 +332,7 @@
    acpigen_emit_namestring(name);
 }

+/* Processor() is deprecated. Please use Device() instead */
 void acpigen_write_processor(u8 cpuindex, u32 pblock_addr, u8 pblock_len)
 {
 /*

Change in coreboot[master]: x86/acpigen: Add comment on Deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37876

to look at the new patch set (#2).

Change subject: x86/acpigen: Add comment on Deprecated 'Processor()'
......................................................................

x86/acpigen: Add comment on Deprecated 'Processor()'

To be compliant with ACPI specification, please use Device() instead
of Processor().
Processor() operator is deprecated.

Change-Id: Ic9ea2ed6a2128dc4fe94155d098c2a4f7c24d82f
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/acpigen.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/37876/2

Change in coreboot[master]: x86/acpigen: Add comment on deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Matt DeVillier, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37876

to look at the new patch set (#3).

Change subject: x86/acpigen: Add comment on deprecated 'Processor()'
......................................................................

x86/acpigen: Add comment on deprecated 'Processor()'

To be compliant with ACPI specification, please use Device() instead
of Processor().
Processor() operator is deprecated.

Change-Id: Ic9ea2ed6a2128dc4fe94155d098c2a4f7c24d82f
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/acpigen.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/37876/3

Change in coreboot[master]: src: Add comment on deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Matt DeVillier, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37876

to look at the new patch set (#5).

Change subject: src: Add comment on deprecated 'Processor()'
......................................................................

src: Add comment on deprecated 'Processor()'

To be compliant with ACPI specification, please use Device() instead
of Processor().
Processor() operator is deprecated.

Change-Id: Ic9ea2ed6a2128dc4fe94155d098c2a4f7c24d82f
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/acpigen.c
M src/arch/x86/include/arch/acpigen.h
M src/cpu/intel/model_2065x/acpi.c
M src/cpu/intel/model_206ax/acpi.c
M src/cpu/intel/speedstep/acpi.c
M src/soc/amd/picasso/acpi.c
M src/soc/amd/stoneyridge/acpi.c
M src/soc/intel/baytrail/acpi.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/broadwell/acpi.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/skylake/acpi.c
12 files changed, 13 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/37876/5

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Patrick Rudolph, Matt DeVillier, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37876

to look at the new patch set (#6).

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

src: Add comments on deprecated 'Processor()'

To be compliant with ACPI specification, please use Device() instead
of Processor().
Processor() operator is deprecated.

Change-Id: Ic9ea2ed6a2128dc4fe94155d098c2a4f7c24d82f
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/acpigen.c
M src/arch/x86/include/arch/acpigen.h
M src/cpu/intel/model_2065x/acpi.c
M src/cpu/intel/model_206ax/acpi.c
M src/cpu/intel/speedstep/acpi.c
M src/soc/amd/picasso/acpi.c
M src/soc/amd/stoneyridge/acpi.c
M src/soc/intel/baytrail/acpi.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/broadwell/acpi.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/skylake/acpi.c
12 files changed, 13 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/37876/6

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Patrick Rudolph, Matt DeVillier, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37876

to look at the new patch set (#7).

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

src: Add comments on deprecated 'Processor()'

To be compliant with ACPI specification, please use Device() instead
of Processor().
Processor() operator is deprecated.

Change-Id: Ic9ea2ed6a2128dc4fe94155d098c2a4f7c24d82f
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/acpigen.c
M src/arch/x86/include/arch/acpigen.h
M src/cpu/intel/model_2065x/acpi.c
M src/cpu/intel/model_206ax/acpi.c
M src/cpu/intel/speedstep/acpi.c
M src/soc/amd/picasso/acpi.c
M src/soc/amd/stoneyridge/acpi.c
M src/soc/intel/baytrail/acpi.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/broadwell/acpi.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/skylake/acpi.c
12 files changed, 13 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/37876/7

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

Patch Set 8:

(1 comment)

Personal I believe to put the warning in build time to warn developer will be better? I believe current ASL already support that?

https://review.coreboot.org/c/coreboot/+/37876/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37876/8//COMMIT_MSG@9 
PS8, Line 9:  ACPI specification,
From which revision?

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

Patch Set 8:

(1 comment)
> Patch Set 8:
>
> (1 comment)
>
> Personal I believe to put the warning in build time to warn developer will be better? I believe current ASL already support that?

currently, Jenkins is running very old IASL version. so no warning is issued until we send a patch to upgrade IASL toolchain

https://review.coreboot.org/c/coreboot/+/37876/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37876/8//COMMIT_MSG@9 
PS8, Line 9:  ACPI specification,
> From which revision?

IASL version 20190816

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37876/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37876/8//COMMIT_MSG@9 
PS8, Line 9:  ACPI specification,
> IASL version 20190816

Would you like to add that into commit message?

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

Patch Set 8: Code-Review+1

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Patrick Rudolph, Matt DeVillier, Lance Zhao, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37876

to look at the new patch set (#9).

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

src: Add comments on deprecated 'Processor()'

To be compliant with ACPI specification, please use Device() instead
of Processor().
IASL version 20190816 deprecate use of Processor().

Change-Id: Ic9ea2ed6a2128dc4fe94155d098c2a4f7c24d82f
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/acpigen.c
M src/arch/x86/include/arch/acpigen.h
M src/cpu/intel/model_2065x/acpi.c
M src/cpu/intel/model_206ax/acpi.c
M src/cpu/intel/speedstep/acpi.c
M src/soc/amd/picasso/acpi.c
M src/soc/amd/stoneyridge/acpi.c
M src/soc/intel/baytrail/acpi.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/broadwell/acpi.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/skylake/acpi.c
12 files changed, 13 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/37876/9

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

Patch Set 9:

(1 comment)

Thx

https://review.coreboot.org/c/coreboot/+/37876/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37876/8//COMMIT_MSG@9 
PS8, Line 9:  ACPI specification,
> Would you like to add that into commit message?

Done

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

Patch Set 9:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37876/9//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37876/9//COMMIT_MSG@10 
PS9, Line 10: of Processor().
Please add a blank line between paragraphs.

https://review.coreboot.org/c/coreboot/+/37876/9//COMMIT_MSG@11 
PS9, Line 11: deprecate
deprecates/warns about

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

Patch Set 9: Code-Review+2

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Patrick Rudolph, Matt DeVillier, Lance Zhao, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37876

to look at the new patch set (#10).

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

src: Add comments on deprecated 'Processor()'

To be compliant with ACPI specification, please use Device() instead
of Processor().

IASL version 20190816 deprecates/warns about use of Processor().

Change-Id: Ic9ea2ed6a2128dc4fe94155d098c2a4f7c24d82f
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/acpigen.c
M src/arch/x86/include/arch/acpigen.h
M src/cpu/intel/model_2065x/acpi.c
M src/cpu/intel/model_206ax/acpi.c
M src/cpu/intel/speedstep/acpi.c
M src/soc/amd/picasso/acpi.c
M src/soc/amd/stoneyridge/acpi.c
M src/soc/intel/baytrail/acpi.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/broadwell/acpi.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/skylake/acpi.c
12 files changed, 13 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/37876/10

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

Patch Set 10:

(2 comments)

Thx

https://review.coreboot.org/c/coreboot/+/37876/9//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37876/9//COMMIT_MSG@10 
PS9, Line 10: of Processor().
> Please add a blank line between paragraphs.

Done

https://review.coreboot.org/c/coreboot/+/37876/9//COMMIT_MSG@11 
PS9, Line 11: deprecate
> deprecates/warns about

Done

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

Patch Set 10:

ping :)

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

Patch Set 10:

I'm not sure if these comments will create any kind of action. And I mean, what's the right way to go about this? Should acpi_write_processor be adapted to not emit a Processor() but a Device()? In that case, the comments at all the call sites are misguided.

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

Patch Set 10:
> Patch Set 10:
>
> I'm not sure if these comments will create any kind of action. And I mean, what's the right way to go about this? Should acpi_write_processor be adapted to not emit a Processor() but a Device()? In that case, the comments at all the call sites are misguided.

Yes, shouldn't use "Processor()".
you are right. I'll keep the comment only in arc/x86

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Patrick Rudolph, Matt DeVillier, Lance Zhao, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37876

to look at the new patch set (#11).

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

src: Add comments on deprecated 'Processor()'

To be compliant with ACPI specification, please use Device() instead
of Processor().

IASL version 20190816 deprecates/warns about use of Processor().

Change-Id: Ic9ea2ed6a2128dc4fe94155d098c2a4f7c24d82f
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/acpigen.c
M src/arch/x86/include/arch/acpigen.h
2 files changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/37876/11

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

Patch Set 11:
> Patch Set 10:
> > Patch Set 10:
> >
> > I'm not sure if these comments will create any kind of action. And I mean, what's the right way to go about this? Should acpi_write_processor be adapted to not emit a Processor() but a Device()? In that case, the comments at all the call sites are misguided.
>
> Yes, shouldn't use "Processor()".
> you are right. I'll keep the comment only in arc/x86

Did Kernel side have backward compatibility? Do we need to keep both definition and let OS to choose?

Change in coreboot[master]: src: Add comments on deprecated 'Processor()'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37876 )

Change subject: src: Add comments on deprecated 'Processor()'
......................................................................

Abandoned

boring