Attention is currently required from: Arthur Heymans, Christian Walter, Jincheng Li, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Patrick Rudolph, Paul Menzel, Shuo Liu, Tim Chu.
Angel Pons has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/84314?usp=email )
Change subject: soc/intel/xeon_sp: Reserve PRMRR
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
File src/include/cpu/x86/mtrr.h:
https://review.coreboot.org/c/coreboot/+/84314/comment/a2ca72b3_7b8a2df4?usp... :
PS6, Line 171: /*
: * fls64: find least significant bit set in a 64-bit word
: * As samples, fls64(0x0) = 64; fls64(0x4400) = 10;
: * fls64(0x40400000000) = 34.
: */
: static uint32_t fls64(uint64_t x)
: {
: uint32_t lo = (uint32_t)x;
: if (lo)
: return fls(lo);
: uint32_t hi = x >> 32;
: return fls(hi) + 32;
: }
Acknowledged
CB:85104
File src/soc/intel/xeon_sp/uncore.c:
https://review.coreboot.org/c/coreboot/+/84314/comment/ea88cc0c_446b41b9?usp... :
PS7, Line 173: *base = msr_read(msr_addr);
:
: /* Clean the BIT0-BIT11 to get the base address */
: *base = (*base >> RANGE_SHIFT) << RANGE_SHIFT;
I think there's a macro somewhere to do the `(1 << x) - 1` thing but I can't find it:
```suggestion
/* Mask out bits 0-11 to get the base address */
*base = msr_read(msr_addr) & ~((1 << RANGE_SHIFT) - 1);
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84314?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I81d17b1376459510f7c0d43ba4b519b1f2bd3e1f
Gerrit-Change-Number: 84314
Gerrit-PatchSet: 7
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen, Gang C
gang.c.chen@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 12 Nov 2024 07:51:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com