Attention is currently required from: Marc Jones, Furquan Shaikh, Martin Roth, Jonathan Zhang, Johnny Lin, Stefan Reinauer, Rocky Phagura, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49849 )
Change subject: soc/intel/xeon_sp: Add PCH lockdown
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/pch/Kconfig:
https://review.coreboot.org/c/coreboot/+/49849/comment/dbc18f38_2f667a8e
PS4, Line 21: if !XEON_SP_COMMON_BASE
Is there a better way to categorize this, or to have a set of convenience groups for these options? […]
SERVER/CLIENT distinction would be a good starting point. I think I brought this up in the past, but didn't materialize.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab97123e487f4f13f874f364a9c51723d234d4f0
Gerrit-Change-Number: 49849
Gerrit-PatchSet: 4
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Rocky Phagura
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 03 Mar 2021 09:15:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment