Attention is currently required from: Hung-Te Lin, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86017?usp=email )
Change subject: soc/mediatek/mt8196: Add thermal driver
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/mt8196/mt_thermal_sram_init.c:
https://review.coreboot.org/c/coreboot/+/86017/comment/85d1e41e_81423e05?usp... :
PS2, Line 32: int i = 0;
: uint32_t pattern = 0xffffffff;
: uint32_t *buff = (uint32_t *)THERMAL_STAT_SRAM_BASE;
: for (i = 0; i < THERMAL_STAT_SRAM_LEN / 4; i++) {
: *buff = pattern;
: buff++;
: }
Would it be better to align the same style with thermal_cls_sram() function? […]
I'm fine either way. I was just providing an alternative to the current code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86017?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieef94a6909e4da82461351bcb9292e9d01db3362
Gerrit-Change-Number: 86017
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Zhaoqing Jiu
zhaoqing.jiu@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 08:05:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhaoqing Jiu
zhaoqing.jiu@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com