Attention is currently required from: Paul Fagerburg, Paul2 Huang, Kirk Wang, Shou-Chieh Hsu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52626 )
Change subject: mb/google/dedede: Create pirika variant
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
Other than the comment, it looks good.
File src/mainboard/google/dedede/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/52626/comment/f5abb5da_5b595214
PS1, Line 138: bool "-> Pirika"
Is it based on CR50 or TPM2. Please enable the config accordingly. This used to be enabled by default earlier. But with second sourcing of TPM, we need to enable this explicitly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52626
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57bf33deeadacc88800f9ce1d3d54385ba56c798
Gerrit-Change-Number: 52626
Gerrit-PatchSet: 1
Gerrit-Owner: Kirk Wang
Gerrit-Reviewer: Alex1 Kao
alex1_kao@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kirk Wang
kirk_wang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ariel Chang
ariel_chang@pegatron.corp-partner.google.com
Gerrit-CC: Hao Chou
hao_chou@pegatron.corp-partner.google.com
Gerrit-CC: Wayne3 Wang
wayne3_wang@pegatron.corp-partner.google.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Attention: Kirk Wang
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Tue, 04 May 2021 06:51:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment