Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63282 )
Change subject: mb/google/guybrush/var/dewatt: Override SPD file for Samsung parts ......................................................................
mb/google/guybrush/var/dewatt: Override SPD file for Samsung parts
K4U6E3S4AB-MGCL and K4UBE3D4AB-MGCL require special SPD files. This commit overrides the default SPD files used for these parts
BUG=b:224884904 TEST=Verified that Dewatt SKU1 and SKU3 boot with changes
Signed-off-by: Robert Zieba robertzieba@google.com Change-Id: Ibd08f109765933640ea3d0ad442873c30fa14bc4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63282 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc M src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt 2 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Rob Barnes: Looks good to me, approved
diff --git a/src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc b/src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc index 9c4a7e4..c6b64cf 100644 --- a/src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc +++ b/src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc @@ -13,6 +13,6 @@ SPD_SOURCES += spd/lp4x/set-1/spd-empty.hex # ID = 6(0b0110) SPD_SOURCES += spd/lp4x/set-1/spd-empty.hex # ID = 7(0b0111) SPD_SOURCES += spd/lp4x/set-1/spd-empty.hex # ID = 8(0b1000) -SPD_SOURCES += $(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/memory/K4U6E3S4AB-MGCL.hex # ID = 9(0b1001) Parts = K4U6E3S4AB-MGCL +SPD_SOURCES += src/mainboard/google/guybrush/variants/dewatt/memory/K4U6E3S4AB-MGCL.hex # ID = 9(0b1001) Parts = K4U6E3S4AB-MGCL SPD_SOURCES += spd/lp4x/set-1/spd-empty.hex # ID = 10(0b1010) -SPD_SOURCES += $(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/memory/K4UBE3D4AB-MGCL.hex # ID = 11(0b1011) Parts = K4UBE3D4AB-MGCL +SPD_SOURCES += src/mainboard/google/guybrush/variants/dewatt/memory/K4UBE3D4AB-MGCL.hex # ID = 11(0b1011) Parts = K4UBE3D4AB-MGCL diff --git a/src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt b/src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt index 9d79210..f2c3024 100644 --- a/src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt +++ b/src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt @@ -7,8 +7,8 @@ K4U6E3S4AA-MGCR H9HCNNNCPMMLXR-NEE K4UBE3D4AA-MGCR -K4U6E3S4AB-MGCL,*9 +K4U6E3S4AB-MGCL,9,K4U6E3S4AB-MGCL.hex H54G46CYRBX267 MT53E512M32D1NP-046 WT:B H54G56CYRBX247 -K4UBE3D4AB-MGCL,*11 +K4UBE3D4AB-MGCL,11,K4UBE3D4AB-MGCL.hex