Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43334 )
Change subject: mb/google/zork: enable i2c devices in verstage ......................................................................
mb/google/zork: enable i2c devices in verstage
Zork devices shut down the i2c controllers in S3 to save power. On resume, they need to be enabled in verstage before being accessed or the system hangs.
BUG=b:160834101 TEST=Resume works with psp_verstage.
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I7b8c7e12847876dab4ca74d67d3c41e63d7727cf --- M src/mainboard/google/zork/verstage.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/43334/1
diff --git a/src/mainboard/google/zork/verstage.c b/src/mainboard/google/zork/verstage.c index 8401196..bcbf396 100644 --- a/src/mainboard/google/zork/verstage.c +++ b/src/mainboard/google/zork/verstage.c @@ -31,5 +31,6 @@
void verstage_mainboard_init(void) { + enable_aoac_devices(); setup_i2c(); }
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43334 )
Change subject: mb/google/zork: enable i2c devices in verstage ......................................................................
Patch Set 1: Code-Review+2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43334 )
Change subject: mb/google/zork: enable i2c devices in verstage ......................................................................
Patch Set 1: Code-Review+2
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43334 )
Change subject: mb/google/zork: enable i2c devices in verstage ......................................................................
mb/google/zork: enable i2c devices in verstage
Zork devices shut down the i2c controllers in S3 to save power. On resume, they need to be enabled in verstage before being accessed or the system hangs.
BUG=b:160834101 TEST=Resume works with psp_verstage.
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I7b8c7e12847876dab4ca74d67d3c41e63d7727cf Reviewed-on: https://review.coreboot.org/c/coreboot/+/43334 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Raul Rangel rrangel@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/verstage.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/google/zork/verstage.c b/src/mainboard/google/zork/verstage.c index 8401196..bcbf396 100644 --- a/src/mainboard/google/zork/verstage.c +++ b/src/mainboard/google/zork/verstage.c @@ -31,5 +31,6 @@
void verstage_mainboard_init(void) { + enable_aoac_devices(); setup_i2c(); }
-
Aaron Durbin (Code Review) -
Martin Roth (Code Review)
-
Raul Rangel (Code Review)