Attention is currently required from: Bao Zheng, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63319 )
Change subject: amdfwtool: Add a macro to set explicitly second gen for old SOCs
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
looks good to me
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/63319/comment/cc0ebf7c_34d90dbf
PS1, Line 1808: amd_romsig->efs_gen.reserved = 0;
i wonder if this should also be moved inside the set_efs_table function and if that should also be set in the case where efs_gen.gen is set to EFS_BEFORE_SECOND_GEN
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63319
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65caa11e835d2ff52bec4b8904057bbced434891
Gerrit-Change-Number: 63319
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Sun, 03 Apr 2022 17:15:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment