Change in coreboot[master]: mb/system76/lemp9: enable TPM2

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Jeremy Soller (Code Review)

20 Jul 2020 20 Jul '20

11:32 p.m.

Jeremy Soller has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43626 )

Change subject: mb/system76/lemp9: enable TPM2 ......................................................................

mb/system76/lemp9: enable TPM2

Tested on lemp9, TPM2 shows up in coreboot console

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I7878c8806c453369bc14d69ecd2bf2533d8821d9 --- M src/mainboard/system76/lemp9/Kconfig M src/mainboard/system76/lemp9/devicetree.cb M src/mainboard/system76/lemp9/gpio.h 3 files changed, 8 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/43626/1

diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig index c606d91..8286ba3 100644 --- a/src/mainboard/system76/lemp9/Kconfig +++ b/src/mainboard/system76/lemp9/Kconfig @@ -11,9 +11,8 @@ select GENERIC_SPD_BIN select INTEL_GMA_HAVE_VBT select INTEL_LPSS_UART_FOR_CONSOLE -# Chip select 2 is not yet supported by intel fast_spi -# select MAINBOARD_HAS_SPI_TPM_CR50 -# select MAINBOARD_HAS_TPM2 + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_TPM2 select NO_UART_ON_SUPERIO select SOC_INTEL_COMETLAKE select SOC_INTEL_COMMON_BLOCK_HDA @@ -90,13 +89,4 @@ bool default n

-# Chip select 2 is not yet supported by intel fast_spi -#config DRIVER_TPM_SPI_BUS -# hex -# default 0x0 -# -#config DRIVER_TPM_SPI_CHIP -# int -# default 2 - endif diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 8d77aa9..2ad0904 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -259,7 +259,11 @@ device pci 1e.1 off end # UART #1 device pci 1e.2 off end # GSPI #0 device pci 1e.3 off end # GSPI #1 - device pci 1f.0 on end # LPC Interface + device pci 1f.0 on # LPC Interface + chip drivers/pc80/tpm + device pnp 0c31.0 on end + end + end device pci 1f.1 off end # P2SB device pci 1f.2 off end # Power Management Controller device pci 1f.3 on end # Intel HDA diff --git a/src/mainboard/system76/lemp9/gpio.h b/src/mainboard/system76/lemp9/gpio.h index e71197c..881bd36 100644 --- a/src/mainboard/system76/lemp9/gpio.h +++ b/src/mainboard/system76/lemp9/gpio.h @@ -76,7 +76,7 @@ PAD_CFG_NF(GPP_A6, NONE, DEEP, NF1),

// GSPI0 - // TODO - TPM_PIRQ# + // TPM_PIRQ# PAD_CFG_NC(GPP_A7),

// LPC

Attachments:

attachment.htm (text/html — 5.2 KB)

Show replies by date

Angel Pons (Code Review)

21 Jul 21 Jul

12:01 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43626 )

Change subject: mb/system76/lemp9: enable TPM2 ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43626/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43626/5//COMMIT_MSG@9 PS5, Line 9: Tested on lemp9, TPM2 shows up in coreboot console Please add a period at the end of the sentence.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7878c8806c453369bc14d69ecd2bf2533d8821d9 Gerrit-Change-Number: 43626 Gerrit-PatchSet: 5 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Mon, 20 Jul 2020 22:01:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jeremy Soller (Code Review)

12:02 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43626

to look at the new patch set (#7).

Change subject: mb/system76/lemp9: enable TPM2 ......................................................................

mb/system76/lemp9: enable TPM2

Tested on lemp9, TPM2 shows up in coreboot console

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/43626/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/43626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7878c8806c453369bc14d69ecd2bf2533d8821d9 Gerrit-Change-Number: 43626 Gerrit-PatchSet: 7 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Jeremy Soller (Code Review)

12:11 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43626

to look at the new patch set (#8).

Change subject: mb/system76/lemp9: enable TPM2 ......................................................................

mb/system76/lemp9: enable TPM2

Tested on lemp9, TPM2 shows up in coreboot console.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/43626/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/43626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7878c8806c453369bc14d69ecd2bf2533d8821d9 Gerrit-Change-Number: 43626 Gerrit-PatchSet: 8 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

12:52 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43626 )

Change subject: mb/system76/lemp9: enable TPM2 ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43626/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/gpio.h:

https://review.coreboot.org/c/coreboot/+/43626/9/src/mainboard/system76/lemp... PS9, Line 78: // GSPI0 : // TPM_PIRQ# : PAD_CFG_NC(GPP_A7), : this is required, as I commented on github already :P see CB:43637

-- To view, visit https://review.coreboot.org/c/coreboot/+/43626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7878c8806c453369bc14d69ecd2bf2533d8821d9 Gerrit-Change-Number: 43626 Gerrit-PatchSet: 9 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Michael Niewöhner Gerrit-Comment-Date: Mon, 20 Jul 2020 22:52:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jeremy Soller (Code Review)

4:20 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43626

to look at the new patch set (#12).

Change subject: mb/system76/lemp9: enable TPM2 ......................................................................

mb/system76/lemp9: enable TPM2

Tested on lemp9, TPM2 shows up in coreboot console.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/43626/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/43626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7878c8806c453369bc14d69ecd2bf2533d8821d9 Gerrit-Change-Number: 43626 Gerrit-PatchSet: 12 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

11:46 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43626 )

Change subject: mb/system76/lemp9: enable TPM2 ......................................................................

Patch Set 15:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43626/15//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43626/15//COMMIT_MSG@7 PS15, Line 7: mb/system76/lemp9: enable TPM2 let's add some more details; CB:43641

-- To view, visit https://review.coreboot.org/c/coreboot/+/43626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7878c8806c453369bc14d69ecd2bf2533d8821d9 Gerrit-Change-Number: 43626 Gerrit-PatchSet: 15 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 21:46:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jeremy Soller (Code Review)

22 Jul 22 Jul

2:45 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43626

to look at the new patch set (#16).

Change subject: mb/system76/lemp9: enable TPM2 ......................................................................

mb/system76/lemp9: enable TPM2

Tested on lemp9, TPM2 shows up in coreboot console.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/43626/16

-- To view, visit https://review.coreboot.org/c/coreboot/+/43626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7878c8806c453369bc14d69ecd2bf2533d8821d9 Gerrit-Change-Number: 43626 Gerrit-PatchSet: 16 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Jeremy Soller (Code Review)

4:09 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43626

to look at the new patch set (#18).

Change subject: mb/system76/lemp9: enable TPM2 ......................................................................

mb/system76/lemp9: enable TPM2

Tested on lemp9, TPM2 shows up in coreboot console.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/43626/18

-- To view, visit https://review.coreboot.org/c/coreboot/+/43626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7878c8806c453369bc14d69ecd2bf2533d8821d9 Gerrit-Change-Number: 43626 Gerrit-PatchSet: 18 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

24 Jul 24 Jul

6:57 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43626 )

Change subject: mb/system76/lemp9: enable TPM2 ......................................................................

Patch Set 19:

@Jeremy could you test CB:43641, please?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7878c8806c453369bc14d69ecd2bf2533d8821d9 Gerrit-Change-Number: 43626 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 24 Jul 2020 16:57:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

27 Jul 27 Jul

10:57 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43626 )

Change subject: mb/system76/lemp9: enable TPM2 ......................................................................

Patch Set 19: Code-Review-1

-1 to ensure this doesn't get merged in its incomplete state

-- To view, visit https://review.coreboot.org/c/coreboot/+/43626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7878c8806c453369bc14d69ecd2bf2533d8821d9 Gerrit-Change-Number: 43626 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 27 Jul 2020 08:57:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

31 Aug 31 Aug

1:05 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43626 )

Change subject: mb/system76/lemp9: enable TPM2 ......................................................................

Patch Set 19: Code-Review-2

CB:43641 was merged; drop this

-- To view, visit https://review.coreboot.org/c/coreboot/+/43626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7878c8806c453369bc14d69ecd2bf2533d8821d9 Gerrit-Change-Number: 43626 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 30 Aug 2020 23:05:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jeremy Soller (Code Review)

4 Sep 4 Sep

12:02 a.m.

Jeremy Soller has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43626 )

Change subject: mb/system76/lemp9: enable TPM2 ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/43626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7878c8806c453369bc14d69ecd2bf2533d8821d9 Gerrit-Change-Number: 43626 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1542

days inactive

1587

days old

coreboot-gerrit@coreboot.org

12 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Jeremy Soller (Code Review)
Michael Niewöhner (Code Review)