HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38369 )
Change subject: mb/lenovo/g505s: Fix typos ......................................................................
mb/lenovo/g505s: Fix typos
Change-Id: I38fdc8ff92cffe467b2ca176e841bf601be9d24b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/g505s/BiosCallOuts.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/38369/1
diff --git a/src/mainboard/lenovo/g505s/BiosCallOuts.c b/src/mainboard/lenovo/g505s/BiosCallOuts.c index 2eb36fa..876b524 100644 --- a/src/mainboard/lenovo/g505s/BiosCallOuts.c +++ b/src/mainboard/lenovo/g505s/BiosCallOuts.c @@ -100,7 +100,7 @@ */ static void oem_fan_control(FCH_DATA_BLOCK *FchParams) { - /* Enable IMC fan control. the recommand way */ + /* Enable IMC fan control. the recommend way */ if (CONFIG(HUDSON_IMC_FWM)) { imc_reg_init();
@@ -156,11 +156,11 @@
/* NOTE: * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. - * so we remove it from AGESA code. Please Seee FchInitLateHwm. + * AGESA put EcDefaultMassege as global data in ROM, so we can't overwrite it. + * so we remove it from AGESA code. Please See FchInitLateHwm. */ } else { - /* HWM fan control, the way not recommand */ + /* HWM fan control, the way not recommend */ FchParams->Imc.ImcEnable = FALSE; FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38369 )
Change subject: mb/lenovo/g505s: Fix typos ......................................................................
Patch Set 1: Code-Review+2
Alexander Couzens has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38369 )
Change subject: mb/lenovo/g505s: Fix typos ......................................................................
mb/lenovo/g505s: Fix typos
Change-Id: I38fdc8ff92cffe467b2ca176e841bf601be9d24b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38369 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Alexander Couzens lynxis@fe80.eu --- M src/mainboard/lenovo/g505s/BiosCallOuts.c 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Alexander Couzens: Looks good to me, approved
diff --git a/src/mainboard/lenovo/g505s/BiosCallOuts.c b/src/mainboard/lenovo/g505s/BiosCallOuts.c index 2eb36fa..876b524 100644 --- a/src/mainboard/lenovo/g505s/BiosCallOuts.c +++ b/src/mainboard/lenovo/g505s/BiosCallOuts.c @@ -100,7 +100,7 @@ */ static void oem_fan_control(FCH_DATA_BLOCK *FchParams) { - /* Enable IMC fan control. the recommand way */ + /* Enable IMC fan control. the recommend way */ if (CONFIG(HUDSON_IMC_FWM)) { imc_reg_init();
@@ -156,11 +156,11 @@
/* NOTE: * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. - * so we remove it from AGESA code. Please Seee FchInitLateHwm. + * AGESA put EcDefaultMassege as global data in ROM, so we can't overwrite it. + * so we remove it from AGESA code. Please See FchInitLateHwm. */ } else { - /* HWM fan control, the way not recommand */ + /* HWM fan control, the way not recommend */ FchParams->Imc.ImcEnable = FALSE; FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */
-
Alexander Couzens (Code Review) -
HAOUAS Elyes (Code Review)