Attention is currently required from: Raul Rangel, Furquan Shaikh, Martin Roth, Karthik Ramasubramanian, Karthikeyan Ramasubramanian. Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51543 )
Change subject: mb/google/guybrush: Add initial I2C configuration ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51543/comment/479cb8d4_24f12857 PS2, Line 38: # I2C Config : #+-------------------+---------------------------+ : #| Field | Value | : #+-------------------+---------------------------+ : #| I2C0 | Trackpad | : #| I2C1 | Touchscreen | : #| I2C2 | Speaker, Codec, P-SAR | : #| I2C3 | H1/D2 TPM | : #+-------------------+---------------------------+ : register "i2c[0]" = "{ : .speed = I2C_SPEED_FAST, : }" : : register "i2c[1]" = "{ : .speed = I2C_SPEED_FAST, : }" : : register "i2c[2]" = "{ : .speed = I2C_SPEED_FAST, : }" : : register "i2c[3]" = "{ : .speed = I2C_SPEED_FAST, : }" Does this need to be in the variant or can it move to the baseboard?