Sunwei Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48893 )
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu ......................................................................
mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu
The katsu project will be using eMCP board design.
BUG=b:176271935 TEST=Boots on chromebook katsu successfully.
Signed-off-by: Sunway lisunwei@huaqin.corp-partner.google.com Change-Id: I733a9a79e2ea6501e26bf79bfce2b1934a295342 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/48893/1
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index ae18263..286d9f8 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -36,7 +36,7 @@ select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER - select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE || BOARD_GOOGLE_KAKADU + select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE || BOARD_GOOGLE_KAKADU || BOARD_GOOGLE_KATSU
config MAINBOARD_DIR string
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48893 )
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu ......................................................................
Patch Set 1: Code-Review+2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48893 )
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48893/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48893/1//COMMIT_MSG@13 PS1, Line 13: please add
BRANCH=kukui
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48893 )
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu ......................................................................
Patch Set 1: -Code-Review
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48893
to look at the new patch set (#2).
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu ......................................................................
mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu
The katsu project will be using eMCP board design.
BUG=b:176271935 TEST=Boots on chromebook katsu successfully. BRANCH=kukui Signed-off-by: Sunway lisunwei@huaqin.corp-partner.google.com Change-Id: I733a9a79e2ea6501e26bf79bfce2b1934a295342 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/48893/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48893 )
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu ......................................................................
Patch Set 2: Code-Review+2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48893 )
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48893/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48893/2//COMMIT_MSG@14 PS2, Line 14: S need one blank line between XXX= and XXX: blocks.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48893
to look at the new patch set (#3).
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu ......................................................................
mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu
The katsu project will be using eMCP board design.
BUG=b:176271935 TEST=Boots on chromebook katsu successfully. BRANCH=kukui
Signed-off-by: Sunway lisunwei@huaqin.corp-partner.google.com Change-Id: I733a9a79e2ea6501e26bf79bfce2b1934a295342 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/48893/3
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48893 )
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu ......................................................................
Patch Set 3: Code-Review+2
Attention is currently required from: Sunwei Li. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48893 )
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48893/comment/b601c9c5_ba0f352b PS2, Line 14: S
need one blank line between XXX= and XXX: blocks.
Ack
Attention is currently required from: Sunwei Li. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48893 )
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48893/comment/ad9d4153_d47dc91d PS1, Line 13:
please add […]
Ack
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48893 )
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu ......................................................................
mb/google/kukui: Enable MT8183_DRAM_EMCP for katsu
The katsu project will be using eMCP board design.
BUG=b:176271935 TEST=Boots on chromebook katsu successfully. BRANCH=kukui
Signed-off-by: Sunway lisunwei@huaqin.corp-partner.google.com Change-Id: I733a9a79e2ea6501e26bf79bfce2b1934a295342 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48893 Reviewed-by: Yu-Ping Wu yupingso@google.com Reviewed-by: Hung-Te Lin hungte@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index b91dfa7..3e9374e 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -36,7 +36,7 @@ select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER - select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE || BOARD_GOOGLE_KAKADU + select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE || BOARD_GOOGLE_KAKADU || BOARD_GOOGLE_KATSU
config MAINBOARD_DIR string
-
Hung-Te Lin (Code Review) -
Sunwei Li (Code Review)
-
Yu-Ping Wu (Code Review)