Attention is currently required from: Jakub Czapiga.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69761 )
Change subject: vboot/vboot_common: Fix vboot_save_data() code exclusion guard ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69761/comment/504253e0_f4140f90 PS4, Line 12: reduction of undefined references.
I'm marking this comment as resolved due to no response for a week.
Sorry sorry, have been swamped for a couple of weeks. Have looked at it now, can confirm the compiler is stupid here: ``` 0: 53 push %ebx 1: 83 ec 08 sub $0x8,%esp 4: 8b 5c 24 10 mov 0x10(%esp),%ebx # load ctx 8: 8b 03 mov (%ebx),%eax # load flags a: a9 02 04 00 00 test $0x402,%eax # test flags f: 74 0d je 1e <vboot_save_data+0x1e> (File Offset: 0xab) 11: 83 ec 0c sub $0xc,%esp # die path 14: 68 00 00 00 00 push $0x0 15: R_386_32 .rodata.vboot_save_data.str1.1 19: e8 fc ff ff ff call 1a <vboot_save_data+0x1a> (File Offset: 0xa7) 1a: R_386_PC32 die 1e: a8 02 test $0x2,%al # test KERNEL_SECDATA flag again even if we jumped over the die path 20: 74 25 je 47 <vboot_save_data+0x47> (File Offset: 0xd4) (CONFIG(VBOOT_MOCK_SECDATA) || tlcl_lib_init() == VB2_SUCCESS)) { 22: e8 fc ff ff ff call 23 <vboot_save_data+0x23> (File Offset: 0xb0) 23: R_386_PC32 tlcl_lib_init ``` Let's go with your solution.