Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25372 )
Change subject: sdm845: Add QUPv3 FW load & config ......................................................................
Patch Set 63:
(3 comments)
https://review.coreboot.org/#/c/25372/6/src/mainboard/google/cheza/qupv3_con... File src/mainboard/google/cheza/qupv3_config.c:
https://review.coreboot.org/#/c/25372/6/src/mainboard/google/cheza/qupv3_con... PS6, Line 18: struct se_cfg se_mappings[QUPV3_SE_MAX] =
Is the loading of FW from respective protocol init function is needed for OTA upgrade OR something else in terms design ?
Not sure if I understand what you're asking... we definitely want to preserve the ability to update QUP firmware with an RW update where possible. That's why I was asking if it was possible to load the firmware again after it has already been loaded (without rebooting the whole SoC)... because we have to load some QUPs (like EC and TPM SPI) in RO firmware, but then we might want to reload a newer version after we have jumped to RW firmware. This would be a bit easier if each QUP was loaded individually from the respective driver function. However, we can also do the single table approach now and then write a new function to overwrite a single QUP if the need for such an RW update ever actually comes up after shipping.
https://review.coreboot.org/#/c/25372/6/src/soc/qualcomm/sdm845/include/soc/... File src/soc/qualcomm/sdm845/include/soc/qupv3_fw_config.h:
https://review.coreboot.org/#/c/25372/6/src/soc/qualcomm/sdm845/include/soc/... PS6, Line 65: bool dfs_mode;
But modes aren't directly depends on the protocol, for example, SPI can be operated in FIFO as well as DMA mode so, I am keeping that in latest patch.
It looks like we just always want MIXED in practice (except for UART), though? Does MIXED just mean you can do either FIFO or DMA? And since this needs to work for the kernel and we don't know what kind of access the kernel would want to do we'll always end up wanting MIXED? In that case, we can hardcode it.
https://review.coreboot.org/#/c/25372/6/src/soc/qualcomm/sdm845/qupv3_fw_con... File src/soc/qualcomm/sdm845/qupv3_fw_config.c:
https://review.coreboot.org/#/c/25372/6/src/soc/qualcomm/sdm845/qupv3_fw_con... PS6, Line 227: /* HPG section 3.1.7.1 */
We cannot directly release it to you, our tech release team will take care of that. […]
Yes, please initiate a request with your tech team.
-
Julius Werner (Code Review)