Attention is currently required from: Raul Rangel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74112 )
Change subject: mb/google/myst: Enable PCIe devices in devicetree
......................................................................
Patch Set 31:
(1 comment)
File src/mainboard/google/myst/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/74112/comment/8baad13c_fba5c1b5
PS31, Line 101: *dxio_descs = myst_phx_dxio_descriptors;
: *dxio_num = ARRAY_SIZE(myst_phx_dxio_descriptors);
: *ddi_descs = myst_phx_ddi_descriptors;
: *ddi_num = ARRAY_SIZE(myst_phx_ddi_descriptors);
Are these values actually specific to Phoenix? […]
I would expect them to keep working, but I think it's possible that there would be a delta. We could probably just make it myst and update as needed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74112
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icdad785bcb90de036095bcc4219c15f55f4277fe
Gerrit-Change-Number: 74112
Gerrit-PatchSet: 31
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Mon, 10 Apr 2023 17:16:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment