Julius Werner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31745
Change subject: intel/apollolake: Fix incorrect config usage ......................................................................
intel/apollolake: Fix incorrect config usage
This IS_ENABLED(XXX) line should've clearly been IS_ENABLED(CONFIG_XXX). This patch can fix that. However, I don't have (and don't plan to acquire) an affected system to test, so approve at your own risk (or let me know if I should just remove that check instead).
Change-Id: I79a0fca65853798ee45c3779b437864ba3cf2b1e Signed-off-by: Julius Werner jwerner@chromium.org --- M src/soc/intel/apollolake/cpu.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/31745/1
diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c index d1c5f6f..a08f1f0 100644 --- a/src/soc/intel/apollolake/cpu.c +++ b/src/soc/intel/apollolake/cpu.c @@ -73,7 +73,7 @@ /* Clear out pending MCEs */ /* TODO(adurbin): Some of these banks are core vs package scope. For now every CPU clears every bank. */ - if (IS_ENABLED(SOC_INTEL_COMMON_BLOCK_SGX) || + if (IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_SGX) || acpi_get_sleep_type() == ACPI_S5) mca_configure(NULL);
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31745 )
Change subject: intel/apollolake: Fix incorrect config usage ......................................................................
Patch Set 1: Code-Review+2
Hello Aaron Durbin, Patrick Rudolph, HAOUAS Elyes, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31745
to look at the new patch set (#2).
Change subject: intel/apollolake: Fix incorrect config usage ......................................................................
intel/apollolake: Fix incorrect config usage
This IS_ENABLED(XXX) line should've clearly been IS_ENABLED(CONFIG_XXX). This patch can fix that. However, I don't have (and don't plan to acquire) an affected system to test, so approve at your own risk (or let me know if I should just remove that check instead).
Change-Id: I79a0fca65853798ee45c3779b437864ba3cf2b1e Signed-off-by: Julius Werner jwerner@chromium.org --- M src/soc/intel/apollolake/cpu.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/31745/2
Julius Werner has removed a vote on this change.
Change subject: intel/apollolake: Fix incorrect config usage ......................................................................
Removed Verified-1 by build bot (Jenkins) no-reply@coreboot.org
Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31745 )
Change subject: intel/apollolake: Fix incorrect config usage ......................................................................
intel/apollolake: Fix incorrect config usage
This IS_ENABLED(XXX) line should've clearly been IS_ENABLED(CONFIG_XXX). This patch can fix that. However, I don't have (and don't plan to acquire) an affected system to test, so approve at your own risk (or let me know if I should just remove that check instead).
Change-Id: I79a0fca65853798ee45c3779b437864ba3cf2b1e Signed-off-by: Julius Werner jwerner@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/31745 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/soc/intel/apollolake/cpu.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c index d1c5f6f..a08f1f0 100644 --- a/src/soc/intel/apollolake/cpu.c +++ b/src/soc/intel/apollolake/cpu.c @@ -73,7 +73,7 @@ /* Clear out pending MCEs */ /* TODO(adurbin): Some of these banks are core vs package scope. For now every CPU clears every bank. */ - if (IS_ENABLED(SOC_INTEL_COMMON_BLOCK_SGX) || + if (IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_SGX) || acpi_get_sleep_type() == ACPI_S5) mca_configure(NULL);
-
HAOUAS Elyes (Code Review) -
Julius Werner (Code Review)