Attention is currently required from: Paul Menzel, Vamshi Krishna Gopal.
Terry Cheong has posted comments on this change by Terry Cheong. ( https://review.coreboot.org/c/coreboot/+/82794?usp=email )
Change subject: mb/google/brox: Enable Class-D calibration ......................................................................
Patch Set 5:
(3 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/82794/comment/28265e77_503a4e50?usp... : PS2, Line 9: DC offset of class-D amplifier is larger than expectation in Brox.
Please add concrete values.
Added measured values in commit message.
https://review.coreboot.org/c/coreboot/+/82794/comment/bc4210f6_71a83dab?usp... : PS2, Line 10: based : on the updated verb table provided by Realtek
Is that a comment in the bug report?
Yes. Should I include the comment number in the bug report?
File src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/82794/comment/e681efa5_38789aa8?usp... : PS3, Line 116: Class D
In the commit message summary you use a hyphen: Class-D. Please find out the official spelling.
Done. From the datasheet, it should be hyphenated.