Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36035 )
Change subject: vboot: add new vb2ex_abort callback ......................................................................
vboot: add new vb2ex_abort callback
Required for new VB2_ASSERT and VB2_DIE macros in vboot code. (See chromium:972956.)
BUG=b:124141368, chromium:1005700 TEST=make clean && make test-abuild BRANCH=none
Change-Id: I61a1036ccab80862d6eb12f9f72286f29e8478cf Signed-off-by: Joel Kitching kitching@google.com --- M src/security/vboot/vboot_logic.c 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/36035/1
diff --git a/src/security/vboot/vboot_logic.c b/src/security/vboot/vboot_logic.c index d049740..da6231a 100644 --- a/src/security/vboot/vboot_logic.c +++ b/src/security/vboot/vboot_logic.c @@ -87,6 +87,11 @@ return VB2_SUCCESS; }
+void vb2ex_abort(void) +{ + die("vboot has aborted execution; exit\n"); +} + /* No-op stubs that can be overridden by SoCs with hardware crypto support. */ __weak vb2_error_t vb2ex_hwcrypto_digest_init(enum vb2_hash_algorithm hash_alg, uint32_t data_size)
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36035 )
Change subject: vboot: add new vb2ex_abort callback ......................................................................
Patch Set 1: Code-Review+2
Joel Kitching has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36035 )
Change subject: vboot: add new vb2ex_abort callback ......................................................................
vboot: add new vb2ex_abort callback
Required for new VB2_ASSERT and VB2_DIE macros in vboot code. (See chromium:972956.)
BUG=b:124141368, chromium:1005700 TEST=make clean && make test-abuild BRANCH=none
Change-Id: I61a1036ccab80862d6eb12f9f72286f29e8478cf Signed-off-by: Joel Kitching kitching@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36035 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/security/vboot/vboot_logic.c 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/security/vboot/vboot_logic.c b/src/security/vboot/vboot_logic.c index d049740..da6231a 100644 --- a/src/security/vboot/vboot_logic.c +++ b/src/security/vboot/vboot_logic.c @@ -87,6 +87,11 @@ return VB2_SUCCESS; }
+void vb2ex_abort(void) +{ + die("vboot has aborted execution; exit\n"); +} + /* No-op stubs that can be overridden by SoCs with hardware crypto support. */ __weak vb2_error_t vb2ex_hwcrypto_digest_init(enum vb2_hash_algorithm hash_alg, uint32_t data_size)
-
Joel Kitching (Code Review) -
Julius Werner (Code Review)