[S] Change in coreboot[master]: intel/alderlake: remove skip_mbp_hob SOC chip config

[Kapil Porwal (Code Review)]

Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71996 )

Change subject: intel/alderlake: remove skip_mbp_hob SOC chip config
......................................................................

intel/alderlake: remove skip_mbp_hob SOC chip config

Always enable `SkipMbpHob` UPD for RPL and ADL-N FSPs.

BUG=none
TEST=TBD. Build and boot to Google/Kano.

Signed-off-by: Kapil Porwal 
Change-Id: Ia396b633a71aedf592c45b69063ee0528840fd2b
---
M src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb
M src/mainboard/intel/adlrvp/devicetree_n.cb
M src/soc/intel/alderlake/chip.h
M src/soc/intel/alderlake/romstage/fsp_params.c
4 files changed, 16 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/71996/1

diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb
index 16c7ce0..ad5b1f8 100644
--- a/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb
+++ b/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb
@@ -89,8 +89,6 @@
    # Disable Package C-state demotion for nissa baseboard.
    register "disable_package_c_state_demotion" = "1"

-	register "skip_mbp_hob" = "1"
-
    # Intel Common SoC Config
    #+-------------------+---------------------------+
    #| Field             |  Value                    |
diff --git a/src/mainboard/intel/adlrvp/devicetree_n.cb b/src/mainboard/intel/adlrvp/devicetree_n.cb
index b54a134..6776284 100644
--- a/src/mainboard/intel/adlrvp/devicetree_n.cb
+++ b/src/mainboard/intel/adlrvp/devicetree_n.cb
@@ -150,8 +150,6 @@
    	.vnn_icc_max_ma = 500,
    }"

-	register "skip_mbp_hob" = "1"
-
    device domain 0 on
    	device ref igpu on end
    	device ref dtt on
diff --git a/src/soc/intel/alderlake/chip.h b/src/soc/intel/alderlake/chip.h
index 5173b1c..eaabcc3 100644
--- a/src/soc/intel/alderlake/chip.h
+++ b/src/soc/intel/alderlake/chip.h
@@ -666,12 +666,6 @@
     */
    bool disable_package_c_state_demotion;

-	/*
-	 * Enable or Disable Skipping MBP HOB.
-	 * Default is set to 0 and set to 1 to skip the MBP HOB.
-	 */
-	bool skip_mbp_hob;
-
    /* i915 struct for GMA backlight control */
    struct i915_gpu_controller_info gfx;

diff --git a/src/soc/intel/alderlake/romstage/fsp_params.c b/src/soc/intel/alderlake/romstage/fsp_params.c
index 218d345..24c19ce 100644
--- a/src/soc/intel/alderlake/romstage/fsp_params.c
+++ b/src/soc/intel/alderlake/romstage/fsp_params.c
@@ -229,7 +229,7 @@
    	m_cfg->CnviDdrRfim = wifi_generic_cnvi_ddr_rfim_enabled(dev);

/* Skip MBP HOB */
-	m_cfg->SkipMbpHob = config->skip_mbp_hob;
+	m_cfg->SkipMbpHob = CONFIG(SOC_INTEL_RAPTORLAKE) || CONFIG(SOC_INTEL_ALDERLAKE_PCH_N);
 }

static void fill_fspm_audio_params(FSP_M_CONFIG *m_cfg,