Attention is currently required from: Arthur Heymans, ron minnich. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry ......................................................................
Patch Set 3: Verified-1
(15 comments)
File util/cbfstool/linux_trampoline.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/f4f10eef_6f96751a PS3, Line 6: 0xcb, 0x0f, 0x84, 0xc3, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/cda8b626_83288745 PS3, Line 6: 0xcb, 0x0f, 0x84, 0xc3, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/718bca51_34be6753 PS3, Line 11: 0xe8, 0x01, 0x09, 0x00, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0x83, 0xf8, 0x00, 0x74, 0x2d, 0x83, 0x7f, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/d758fb83_bec21556 PS3, Line 11: 0xe8, 0x01, 0x09, 0x00, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0x83, 0xf8, 0x00, 0x74, 0x2d, 0x83, 0x7f, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/455e8a49_5f9b517a PS3, Line 13: 0xe8, 0x83, 0x3b, 0x43, 0x75, 0x10, 0x8b, 0x43, 0x08, 0xa3, 0x70, 0x00, 0x09, 0x00, 0x8b, 0x43, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/1ec9133e_6d61e775 PS3, Line 13: 0xe8, 0x83, 0x3b, 0x43, 0x75, 0x10, 0x8b, 0x43, 0x08, 0xa3, 0x70, 0x00, 0x09, 0x00, 0x8b, 0x43, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/b207731e_47b8ad7c PS3, Line 14: 0x0c, 0xa3, 0x74, 0x00, 0x09, 0x00, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04, 0x49, 0x0f, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/05dea68b_d5831df7 PS3, Line 14: 0x0c, 0xa3, 0x74, 0x00, 0x09, 0x00, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04, 0x49, 0x0f, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/662d0009_eb22ae67 PS3, Line 15: 0x85, 0x7a, 0xff, 0xff, 0xff, 0xb8, 0x00, 0x00, 0x04, 0x00, 0xc7, 0x40, 0x10, 0xff, 0xff, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/d0540152_8fcfa3bd PS3, Line 15: 0x85, 0x7a, 0xff, 0xff, 0xff, 0xb8, 0x00, 0x00, 0x04, 0x00, 0xc7, 0x40, 0x10, 0xff, 0xff, 0x00, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/b41651aa_4352a001 PS3, Line 16: 0x00, 0xc7, 0x40, 0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x40, 0x18, 0xff, 0xff, 0x00, 0x00, 0xc7, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/2dbcd216_bf56015c PS3, Line 16: 0x00, 0xc7, 0x40, 0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x40, 0x18, 0xff, 0xff, 0x00, 0x00, 0xc7, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/84b3b3ff_2cf1d525 PS3, Line 17: 0x40, 0x1c, 0x00, 0x93, 0xcf, 0x00, 0xc6, 0x00, 0x2b, 0x89, 0x40, 0x02, 0x0f, 0x01, 0x10, 0xbe, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/77df8895_a7488978 PS3, Line 17: 0x40, 0x1c, 0x00, 0x93, 0xcf, 0x00, 0xc6, 0x00, 0x2b, 0x89, 0x40, 0x02, 0x0f, 0x01, 0x10, 0xbe, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143063): https://review.coreboot.org/c/coreboot/+/62574/comment/5465a572_b5ce2dee PS3, Line 18: 0x00, 0x00, 0x09, 0x00, 0xff, 0x25, 0x14, 0x02, 0x09, 0x00, 0xf4, 0xeb, 0xfd please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)