Attention is currently required from: Van Chen, Frank Wu, Alan Lee, Dtrain Hsu, Ian Feng, John Hsu, Eric Lai, Amanda Hwang.
David Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69965 )
Change subject: drivers/generic/nau8315: Allow custom _HID from config
......................................................................
Patch Set 1:
(2 comments)
File src/drivers/generic/nau8315/chip.h:
https://review.coreboot.org/c/coreboot/+/69965/comment/76b1ef2b_83f0f9bd
PS1, Line 7: const char *hid;
ex: […]
Hi Eric,
Your idea is to list all support components and assign an array to maintain the the _HID(ACPI ID), right?
enum
{
NAU8825,
NAU8315,
NAU8318,
MAX_HID,
} hid;
const char* nauhid[MAX_HID]={"10508825", "NVTN2010", "NVTN2012"};
File src/drivers/generic/nau8315/nau8315.c:
https://review.coreboot.org/c/coreboot/+/69965/comment/beab67ff_10b42b8c
PS1, Line 29: acpigen_write_name_string("_HID", config->hid);
nau_hid[NAU8315]; […]
As #7 description,
so config->hid = nau_hid[NAU8318];
May I learn the method is applied to all vendors?
Besides, does it exist hardcode due to one driver is just fill in one id?
so the original method from devicetreee.cb to assign _HID should be more flexible?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69965
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6f02e495eeb06290947edc9e44fa25a4ce18956
Gerrit-Change-Number: 69965
Gerrit-PatchSet: 1
Gerrit-Owner: David Lin
CTLIN0@nuvoton.com
Gerrit-Reviewer: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Reviewer: AlanKY Lee
alanky_lee@compal.corp-partner.google.com
Gerrit-Reviewer: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: John Hsu
KCHSU0@nuvoton.com
Gerrit-Reviewer: Mac Chiang
mac.chiang@intel.corp-partner.google.com
Gerrit-Reviewer: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: CT Lin
ctlin0@nuvoton.corp-partner.google.com
Gerrit-Attention: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: John Hsu
KCHSU0@nuvoton.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 01 Dec 2022 06:25:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment