Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46618 )
Change subject: mb/google/volteer/var/voxel: enable GPP_D17 for FCAM_PWR ......................................................................
mb/google/volteer/var/voxel: enable GPP_D17 for FCAM_PWR
enable GPP_D17 for camera power.
BUG=b:169170677 BRANCH=volteer TEST="emerge-volteer coreboot" compiles successfully.
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: I8b5a9a8333ed518883aa3664a115a4ba2e8a0218 --- M src/mainboard/google/volteer/variants/voxel/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/46618/1
diff --git a/src/mainboard/google/volteer/variants/voxel/gpio.c b/src/mainboard/google/volteer/variants/voxel/gpio.c index b5d070b..6e5fc0b 100644 --- a/src/mainboard/google/volteer/variants/voxel/gpio.c +++ b/src/mainboard/google/volteer/variants/voxel/gpio.c @@ -114,7 +114,7 @@ /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */ PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D17 : ISH_GP4 ==> EN_FCAM_PWR */ - PAD_CFG_GPO(GPP_D17, 0, DEEP), + PAD_CFG_GPO(GPP_D17, 1, DEEP),
/* E1 : SPI1_IO2 ==> PEN_DET_ODL */ PAD_CFG_GPI_SCI_LOW(GPP_E1, NONE, DEEP, EDGE_SINGLE),
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46618 )
Change subject: mb/google/volteer/var/voxel: enable GPP_D17 for FCAM_PWR ......................................................................
Patch Set 1: Code-Review+1
YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46618 )
Change subject: mb/google/volteer/var/voxel: enable GPP_D17 for FCAM_PWR ......................................................................
Patch Set 1: Code-Review+1
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46618 )
Change subject: mb/google/volteer/var/voxel: enable GPP_D17 for FCAM_PWR ......................................................................
Patch Set 1:
This patch is also affected by the board.SUPERMICRO_X11SSH_F breakage, so a rebase should fix that.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46618 )
Change subject: mb/google/volteer/var/voxel: enable GPP_D17 for FCAM_PWR ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46618/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46618/1//COMMIT_MSG@9 PS1, Line 9: enable GPP_D17 for camera power. suggestion: "Enable front camera power in ramstage"
Hello build bot (Jenkins), YH Lin, Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, Derek Huang, YH Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46618
to look at the new patch set (#2).
Change subject: mb/google/volteer/var/voxel: enable GPP_D17 for FCAM_PWR ......................................................................
mb/google/volteer/var/voxel: enable GPP_D17 for FCAM_PWR
Enable front camera power in ramstage.
BUG=b:169170677 BRANCH=volteer TEST="emerge-volteer coreboot" compiles successfully.
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: I8b5a9a8333ed518883aa3664a115a4ba2e8a0218 --- M src/mainboard/google/volteer/variants/voxel/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/46618/2
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46618 )
Change subject: mb/google/volteer/var/voxel: enable GPP_D17 for FCAM_PWR ......................................................................
Patch Set 3:
(1 comment)
Patch Set 1:
This patch is also affected by the board.SUPERMICRO_X11SSH_F breakage, so a rebase should fix that.
done
https://review.coreboot.org/c/coreboot/+/46618/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46618/1//COMMIT_MSG@9 PS1, Line 9: enable GPP_D17 for camera power.
suggestion: "Enable front camera power in ramstage"
done, thanks
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46618 )
Change subject: mb/google/volteer/var/voxel: enable GPP_D17 for FCAM_PWR ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46618/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46618/1//COMMIT_MSG@9 PS1, Line 9: enable GPP_D17 for camera power.
done, thanks
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46618 )
Change subject: mb/google/volteer/var/voxel: enable GPP_D17 for FCAM_PWR ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46618 )
Change subject: mb/google/volteer/var/voxel: enable GPP_D17 for FCAM_PWR ......................................................................
mb/google/volteer/var/voxel: enable GPP_D17 for FCAM_PWR
Enable front camera power in ramstage.
BUG=b:169170677 BRANCH=volteer TEST="emerge-volteer coreboot" compiles successfully.
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: I8b5a9a8333ed518883aa3664a115a4ba2e8a0218 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46618 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: YH Lin yueherngl@google.com --- M src/mainboard/google/volteer/variants/voxel/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified YH Lin: Looks good to me, but someone else must approve Sheng-Liang Pan: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/voxel/gpio.c b/src/mainboard/google/volteer/variants/voxel/gpio.c index b5d070b..6e5fc0b 100644 --- a/src/mainboard/google/volteer/variants/voxel/gpio.c +++ b/src/mainboard/google/volteer/variants/voxel/gpio.c @@ -114,7 +114,7 @@ /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */ PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D17 : ISH_GP4 ==> EN_FCAM_PWR */ - PAD_CFG_GPO(GPP_D17, 0, DEEP), + PAD_CFG_GPO(GPP_D17, 1, DEEP),
/* E1 : SPI1_IO2 ==> PEN_DET_ODL */ PAD_CFG_GPI_SCI_LOW(GPP_E1, NONE, DEEP, EDGE_SINGLE),
-
Patrick Georgi (Code Review) -
Sheng-Liang Pan (Code Review)
-
Tim Wawrzynczak (Code Review)
-
YH Lin (Code Review)