Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29470 )
Change subject: mainboard/portwell/m107: Do initial mainboard commit ......................................................................
Patch Set 13:
(6 comments)
https://review.coreboot.org/#/c/29470/11/Documentation/mainboard/portwell/pq... File Documentation/mainboard/portwell/pq7-m107.md:
https://review.coreboot.org/#/c/29470/11/Documentation/mainboard/portwell/pq... PS11, Line 94: | Super I/O | None |
Should this be "Super I/O, EC", like https://review.coreboot. […]
Done
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/Kconfig File src/mainboard/portwell/m107/Kconfig:
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/Kconfig... PS11, Line 30: choice
This line https://review.coreboot.org/c/coreboot/+/29470/11/src/mainboard/portwell/m10... […]
Done
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/board_i... File src/mainboard/portwell/m107/board_info.txt:
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/board_i... PS11, Line 3: Category: misc
sbc?
Done
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/com_ini... File src/mainboard/portwell/m107/com_init.c:
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/com_ini... PS11, Line 24: void car_mainboard_pre_console_init(void)
It can be also used to disable the onboard UART and enable the SuperIO UART in one sway. […]
Done
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/fadt.c File src/mainboard/portwell/m107/fadt.c:
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/fadt.c@... PS11, Line 31: header->asl_compiler_revision = 1;
Is there a reason for setting this to 1? Usually it is set to asl_revision.
Done
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/smihand... File src/mainboard/portwell/m107/smihandler.c:
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/smihand... PS11, Line 25: case 0x99:
Perhaps we can get rid of this file, same as https://review.coreboot. […]
Done
-
Frans Hendriks (Code Review)