Attention is currently required from: Hung-Te Lin, Yu-Ping Wu, hsin-hsiung wang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51056 )
Change subject: WIP: soc/mediatek/mt8192: mt6315: update correct slave id
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51056/comment/6a55d205_c97b1797
PS1, Line 8:
What problem does this fix?
https://review.coreboot.org/c/coreboot/+/51056/comment/5803eddb_d03524e1
PS1, Line 11: 2. update the correct sequence flow of the key protection.
1. Please start sentences with a capital letter.
2. If you enumerate changes, it’s a good indicator to make a separate commit for each change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51056
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd04da8ac55bcc9f9fdbc088d430522c2725ad47
Gerrit-Change-Number: 51056
Gerrit-PatchSet: 1
Gerrit-Owner: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicolas Boichat
drinkcat@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Comment-Date: Wed, 03 Mar 2021 10:33:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment