Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney, Arthur Heymans, Furquan Shaikh, Kyösti Mälkki.
Prasad Malisetty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57614 )
Change subject: libpayload: Export PCIe MMCONF from coreboot to libpayload
......................................................................
Patch Set 18:
(3 comments)
Patchset:
PS16:
Hi Prasad, can we use MMIO instead of MMCONF (throughout this whole CL)? In coreboot, we've agreed […]
Hi Shelley,
Thanks for the review.
I will replace MMCONF with MMIO in next patch series.
-Prasad
File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57614/comment/4773010c_21709d57
PS12, Line 275: void *mmconf_base;
Hi Arthur, […]
Sure, I will share the updated change set
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/57614/comment/c1639dac_63e5e57f
PS8, Line 500: if PCI
Agreed that this should not be moved.
Hi Arthur,
I was getting some conflict between ARM and X86 version pci.c lib. I agree on it.
I will correct it and incorporate the change in next patch version.
Thanks
-Prasad
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ca2be55b98c8d1b86576072078cdda02ac55940
Gerrit-Change-Number: 57614
Gerrit-PatchSet: 18
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 10 Nov 2021 03:42:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-MessageType: comment