[M] Change in coreboot[main]: drivers/intel/fsp2_0: Support FSP 2.4 64-bits

[Subrata Banik (Code Review)]

Attention is currently required from: Andrey Petrov, Appukuttan V K, Arthur Heymans, Bora Guvendik, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Johnny Lin, Jérémy Compostella, Matt DeVillier, Patrick Rudolph, Paul Menzel, Ronak Kanabar, Shuo Liu, Tim Chu, Wonkyu Kim.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80277?usp=email )

Change subject: drivers/intel/fsp2_0: Support FSP 2.4 64-bits
......................................................................

Patch Set 31:

(4 comments)

File src/drivers/intel/fsp2_0/include/fsp/info_header.h:

https://review.coreboot.org/c/coreboot/+/80277/comment/ec81fa32_7f5b73e6 :
PS31, Line 15: #if CONFIG(PLATFORM_USES_FSP2_X86_32)
             : struct fsp_header {
             : 	uint32_t  signature; //FSPH
             : 	uint32_t  header_length;
             : 	uint8_t   res1[2];
             : 	uint8_t   spec_version;
             : 	uint8_t   header_revision;
             : 	uint32_t  image_revision;
             : 	char      image_id[FSP_IMAGE_ID_LENGTH]; // not zero terminated
             : 	uint32_t  image_size;
             : 	uint32_t  image_base;
             : 	uint16_t  image_attribute;
             : 	uint16_t  component_attribute;
             : 	uint32_t  cfg_region_offset;
             : 	uint32_t  cfg_region_size;
             : 	uint32_t  res2;
             : 	uint32_t  temp_ram_init_entry_offset; //initial stack
             : 	uint32_t  res3;
             : 	uint32_t  notify_phase_entry_offset;
             : 	uint32_t  fsp_memory_init_entry_offset;
             : 	uint32_t  temp_ram_exit_entry_offset;
             : 	uint32_t  fsp_silicon_init_entry_offset;
             : 	uint32_t  fsp_multi_phase_si_init_entry_offset;
             : 	uint16_t  extended_image_revision;
             : 	uint16_t  res4;
             : 	uint32_t  fsp_multi_phase_mem_init_entry_offset;
             : 	uint32_t  res5;
             : }  __packed;
             : #else
             : #error You need to implement this struct for x86_64 FSP
             : #endif
             : 
should be a separate CL

File src/drivers/intel/fsp2_0/include/fsp/soc_binding.h:

https://review.coreboot.org/c/coreboot/+/80277/comment/cfa3cfbb_40e34018 :
PS31, Line 10: #include <efi/efi_datatype.h>
i'm not sure why we need this change

File src/drivers/intel/fsp2_0/memory_init.c:

https://review.coreboot.org/c/coreboot/+/80277/comment/348207d6_9a9b8d8d :
PS31, Line 37: static uint8_t temp_ram[CONFIG_FSP_TEMP_RAM_SIZE] __aligned(16);
should be a separate CL

File src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c:

https://review.coreboot.org/c/coreboot/+/80277/comment/4d5cca3a_7b70ab5b :
PS31, Line 15: struct efi_ap_procedure_caller_params {
this file should put into a separate CL (nothing specific to 64-bit here, just calling convention has changed)