Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58917 )
Change subject: cpu/intel: Use unsigned types in `get_cpu_count()`
......................................................................
Patch Set 1:
(1 comment)
File src/cpu/intel/model_1067x/mp_init.c:
https://review.coreboot.org/c/coreboot/+/58917/comment/2f855e54_e26afb15
PS1, Line 26: 0xf
unrelated to what this patch does and not that it would matter here, but isn't that field 8 bits?
I haven't checked, but it doesn't matter (these CPUs have at most 4 cores)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id95e45a3eba384a61c02016b7663ec71c3ae1865
Gerrit-Change-Number: 58917
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 03 Nov 2021 17:41:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment